Let default parameters linter rule support `...` in variadic function
Needs ReviewPublic
Actions

Authored by wjiang on May 4 2017, 2:12 AM.

Tags

None

Referenced Files

	F19208476: D17825.diff
	Tue, Dec 16, 11:10 PM

	F19057301: D17825.id42871.diff
	Fri, Nov 28, 9:55 PM

	F19057300: D17825.id42870.diff
	Fri, Nov 28, 9:55 PM

	F19057299: D17825.id.diff
	Fri, Nov 28, 9:55 PM

	F19038862: D17825.id42870.diff
	Wed, Nov 26, 5:56 AM

	F19030077: D17825.id.diff
	Mon, Nov 24, 8:08 PM

	F19019389: D17825.diff
	Nov 23 2025, 2:19 PM

	F19012774: D17825.id42871.diff
	Nov 22 2025, 2:05 PM

View All Files

Subscribers

epriestley

joshuaspence

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12667: Let default parameters linter rule support `...` in variadic function

Summary

Ref T12667. As titled.

Test Plan

Run added unit test.

Diff Detail

Repository

rARC Arcanist

Branch

arcpatch-D17825

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16797
Build 22417: arc lint + arc unit

Event Timeline

wjiang created this revision.May 4 2017, 2:12 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2017, 2:12 AM

Herald added a subscriber: epriestley. · View Herald Transcript

wjiang added a subscriber: joshuaspence.May 4 2017, 2:13 AM

Minor

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

xhpast/

rules/

ArcanistDefaultParametersXHPASTLinterRule.php

4 lines

100%

__tests__/

default-parameters/

default-parameters.lint-test

2 lines

Diff 42871

View Options

src/lint/linter/xhpast/rules/ArcanistDefaultParametersXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/default-parameters/default-parameters.lint-test

Let default parameters linter rule support `...` in variadic functionNeeds ReviewPublicActions