Differential D17825

Let default parameters linter rule support `...` in variadic function
Needs ReviewPublic
Actions

Authored by wjiang on May 4 2017, 2:12 AM.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12667: Let default parameters linter rule support `...` in variadic function

Summary

Ref T12667. As titled.

Test Plan

Run added unit test.

Diff Detail

Repository

rARC Arcanist

Branch

arcpatch-D17825

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 16797
Build 22417: arc lint + arc unit

Event Timeline

wjiang created this revision.May 4 2017, 2:12 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2017, 2:12 AM

Herald added a subscriber: epriestley. · View Herald Transcript

wjiang added a subscriber: joshuaspence.May 4 2017, 2:13 AM

Minor

Revision Contents
Changeset List

			Path	Coverage (All)	Coverage (Touched)	Packages
M			src/lint/linter/xhpast/rules/ArcanistDefaultParametersXHPASTLinterRule.php (4 lines)	100%	Loading...
M			src/lint/linter/xhpast/rules/__tests__/default-parameters/default-parameters.lint-test (2 lines)	-	-

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42870	3c47357		May 4 2017, 2:12 AM	★	★
Diff 2	42871	3c47357	Minor	May 4 2017, 2:14 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
8e157c90c9e4	2f39ed9109fd	3c4735795a29	Wenzheng Jiang	Let default parameters linter rule support `...` in variadic function (Show More…)	May 4 2017, 2:13 AM

Diff 42871

View Options

src/lint/linter/xhpast/rules/ArcanistDefaultParametersXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/default-parameters/default-parameters.lint-test

Let default parameters linter rule support `...` in variadic functionNeeds ReviewPublicActions