Let default parameters linter rule support `...` in variadic function
Needs ReviewPublic
Actions

Authored by wjiang on May 4 2017, 2:12 AM.

Tags

None

Referenced Files

	F18733585: D17825.id.diff
	Tue, Sep 30, 10:37 PM

	F18628196: D17825.id.diff
	Tue, Sep 16, 5:48 AM

	F18628004: D17825.diff
	Tue, Sep 16, 5:20 AM

	F18612980: D17825.id42871.diff
	Sun, Sep 14, 10:29 AM

	F18283133: D17825.diff
	Aug 23 2025, 12:59 AM

	F18168275: D17825.diff
	Aug 15 2025, 2:53 PM

	F18165691: D17825.diff
	Aug 15 2025, 8:49 AM

	F18094629: D17825.diff
	Aug 7 2025, 10:15 PM

View All Files

Subscribers

epriestley

joshuaspence

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12667: Let default parameters linter rule support `...` in variadic function

Summary

Ref T12667. As titled.

Test Plan

Run added unit test.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16796
Build 22416: arc lint + arc unit

Event Timeline

wjiang created this revision.May 4 2017, 2:12 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2017, 2:12 AM

Herald added a subscriber: epriestley. · View Herald Transcript

wjiang added a subscriber: joshuaspence.May 4 2017, 2:13 AM

Minor

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

xhpast/

rules/

ArcanistDefaultParametersXHPASTLinterRule.php

4 lines

100%

__tests__/

default-parameters/

default-parameters.lint-test

2 lines

Diff 42870

View Options

src/lint/linter/xhpast/rules/ArcanistDefaultParametersXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/default-parameters/default-parameters.lint-test

Let default parameters linter rule support `...` in variadic functionNeeds ReviewPublicActions