Page MenuHomePhabricator
Differential D17815

Modernize PhameBlog with modular transactions
ClosedPublic
Actions

Authored by chad on May 2 2017, 10:14 PM.
Tags
None
Referenced Files
F14034132: D17815.diff
Sat, Nov 9, 10:18 PM
F14020101: D17815.diff
Tue, Nov 5, 11:58 PM
F14017064: D17815.id42840.diff
Mon, Nov 4, 2:05 PM
F14011815: D17815.id42841.diff
Fri, Nov 1, 5:19 AM
F14001492: D17815.id42841.diff
Fri, Oct 25, 8:39 AM
F13984832: D17815.id42840.diff
Sun, Oct 20, 4:17 PM
Unknown Object (File)
Oct 11 2024, 12:52 AM
Unknown Object (File)
Sep 20 2024, 12:44 PM
View All 91 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP21ac19630613: Modernize PhameBlog with modular transactions
Summary

Moves PhameBlog over to the wonderful world of modular transactions and the riches that lay beyond...

Test Plan
  • Create Blog
  • Edit Blog
  • Set Header
  • Delete Header
  • Add picture
  • Archive blog
  • Set incorrect domain values
  • Be irresponsible with subtitle length
  • Activate blog
  • Change description

Diff Detail

Repository
rP Phabricator
Branch
phame-blog-xaction (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phame/xaction/PhameBlogHeaderImageTransaction.php:6XHP16TODO Comment
Advicesrc/applications/phame/xaction/PhameBlogProfileImageTransaction.php:6XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16766
Build 22368: Run Core Tests
Build 22367: arc lint + arc unit

Event Timeline

chad created this revision.May 2 2017, 10:14 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 2 2017, 10:14 PM
Harbormaster completed remote builds in B16766: Diff 42840.May 2 2017, 10:16 PM
epriestley accepted this revision.May 2 2017, 10:38 PM
epriestley added inline comments.
src/applications/phame/xaction/PhameBlogHeaderImageTransaction.php
6

ho ho ho ho

This revision is now accepted and ready to land.May 2 2017, 10:38 PM
Closed by commit rP21ac19630613: Modernize PhameBlog with modular transactions (authored by chad, committed by chad). · Explain WhyMay 2 2017, 10:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42840

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogArchiveController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogProfilePictureController.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditEngine.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditor.php

Loading...
View Options

src/applications/phame/storage/PhameBlog.php

Loading...
View Options

src/applications/phame/storage/PhameBlogTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogDescriptionTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogFullDomainTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogHeaderImageTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogNameTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogParentDomainTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogParentSiteTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogProfileImageTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogStatusTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogSubtitleTransaction.php

Loading...
View Options

src/applications/phame/xaction/PhameBlogTransactionType.php

Loading...
Phabricator · Built by Phacility