Page MenuHomePhabricator
Differential D17788

Fix closed task hovercard background color
ClosedPublic
Actions

Authored by chad on Apr 25 2017, 2:11 AM.
Tags
None
Referenced Files
F18088264: D17788.id42773.diff
Wed, Aug 6, 7:26 AM
F18081283: D17788.id42772.diff
Mon, Aug 4, 11:31 PM
F17934572: D17788.id42772.diff
Wed, Jul 30, 10:40 PM
F17919691: D17788.diff
Wed, Jul 30, 2:49 AM
F17919601: D17788.diff
Wed, Jul 30, 2:43 AM
F17854585: D17788.id.diff
Sun, Jul 27, 3:17 PM
F17833794: D17788.diff
Sat, Jul 26, 1:51 PM
Unknown Object (File)
Jun 20 2025, 1:48 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
amckinley
Maniphest Tasks
T12600: Update Hovercards
Commits
rPe18ce14c203b: Fix closed task hovercard background color
Summary

Ref T12600. This makes the background solid when in hovercard context.

Test Plan

Close a task, view hovercard, see solid background

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Apr 25 2017, 2:11 AM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 25 2017, 2:11 AM
Harbormaster completed remote builds in B16699: Diff 42772.Apr 25 2017, 2:12 AM
epriestley accepted this revision.Apr 25 2017, 2:33 PM

I also noticed that the margin/spacing between the "done" checkbox and projects tags is a little tight -- hard to see here, but there's no spacing between the "√" and "Baboon Discovery":

Screen Shot 2017-04-25 at 7.32.38 AM.png (98×117 px, 9 KB)

This revision is now accepted and ready to land.Apr 25 2017, 2:33 PM
Closed by commit rPe18ce14c203b: Fix closed task hovercard background color (authored by chad, committed by chad). · Explain WhyApr 25 2017, 3:40 PM
This revision was automatically updated to reflect the committed changes.
amckinley edited edge metadata.Apr 25 2017, 4:21 PM

@chad are you a wizard? I noticed this yesterday and was about to file a task.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
phui/
object-item/
1 line
4 lines

Diff 42773

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-hovercard.css

Loading...
Phabricator · Built by Phacility