Fix closed task hovercard background color
ClosedPublic
Actions

Authored by chad on Apr 25 2017, 2:11 AM.

Details

Reviewers

epriestley
amckinley

Maniphest Tasks

T12600: Update Hovercards

Commits

rPe18ce14c203b: Fix closed task hovercard background color

Summary

Ref T12600. This makes the background solid when in hovercard context.

Test Plan

Close a task, view hovercard, see solid background

Diff Detail

Repository

rP Phabricator

Branch

hovercard-fade (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16699
Build 22274: Run Core Tests
Build 22273: arc lint + arc unit

Event Timeline

chad created this revision.Apr 25 2017, 2:11 AM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 25 2017, 2:11 AM

Harbormaster completed remote builds in B16699: Diff 42772.Apr 25 2017, 2:12 AM

I also noticed that the margin/spacing between the "done" checkbox and projects tags is a little tight -- hard to see here, but there's no spacing between the "√" and "Baboon Discovery":

Screen Shot 2017-04-25 at 7.32.38 AM.png (98×117 px, 9 KB)

This revision is now accepted and ready to land.Apr 25 2017, 2:33 PM

Closed by commit rPe18ce14c203b: Fix closed task hovercard background color (authored by chad, committed by chad). · Explain WhyApr 25 2017, 3:40 PM

This revision was automatically updated to reflect the committed changes.

@chad are you a wizard? I noticed this yesterday and was about to file a task.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

phui/

phui-hovercard.css

4 lines

Diff 42772

View Options

resources/celerity/map.php