Page MenuHomePhabricator
Differential D17716

Break all mobile form rendering
AbandonedPublic
Actions

Authored by chad on Apr 17 2017, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 23 2024, 8:56 AM
Unknown Object (File)
Feb 11 2024, 9:44 AM
Unknown Object (File)
Jan 20 2024, 5:47 PM
Unknown Object (File)
Jan 9 2024, 4:36 PM
Unknown Object (File)
Jan 5 2024, 5:47 PM
Unknown Object (File)
Jan 1 2024, 5:57 PM
Unknown Object (File)
Jan 1 2024, 5:57 PM
Unknown Object (File)
Dec 28 2023, 7:00 PM
View All 20 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Summary

I'm not sure I want to ship this, but bumps font-size up on mobile devices.

Test Plan

Lots of different forms on desktop and mobile

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16540
Build 22038: Run Core Tests
Build 22037: arc lint + arc unit

Event Timeline

chad created this revision.Apr 17 2017, 11:52 PM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 17 2017, 11:52 PM
Harbormaster completed remote builds in B16540: Diff 42606.Apr 17 2017, 11:53 PM
epriestley edited edge metadata.Apr 18 2017, 12:08 AM

The zooming is soooooo awful, did this turn it back on on purpose or was that just collateral damage from things happening out of order?

Seems basically fine except for zooming (which is the worst)

webroot/rsrc/css/phui/phui-form.css
119–124

One of these is busted on multi-tokenizer inputs:

Screen Shot 2017-04-17 at 5.07.36 PM.png (312×680 px, 39 KB)

chad added a comment.Apr 18 2017, 12:11 AM

This seems like a lot of work for only a small theoretical benefit

chad abandoned this revision.Apr 18 2017, 12:31 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
view/
page/
3 lines
webroot/
rsrc/
css/
application/
conpherence/
2 lines
phui/
4 lines
33 lines

Diff 42606

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorBarePageView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form.css

Loading...
Phabricator · Built by Phacility