Reduce some code duplication in PhortuneLandingController
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 5:00 PM.

Tags

None

Referenced Files

	F15461549: D17693.diff
	Tue, Apr 1, 9:11 AM

	F15448121: D17693.diff
	Fri, Mar 28, 3:15 AM

	F15438639: D17693.id42547.diff
	Wed, Mar 26, 2:14 AM

	F15436752: D17693.id.diff
	Tue, Mar 25, 4:25 PM

	F15435619: D17693.id42553.diff
	Tue, Mar 25, 9:20 AM

	F15428415: D17693.diff
	Sun, Mar 23, 8:12 PM

	F15427814: D17693.diff
	Sun, Mar 23, 4:08 PM

	F15396662: D17693.id42547.diff
	Sun, Mar 16, 3:42 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12451: Finding your subscriptions / cards on Phacility is non-obvious

Commits

rP7fbb5f2d9210: Reduce some code duplication in PhortuneLandingController

Summary

Ref T12451. This code is the same as the other code.

Test Plan

Went through the default-account case with this code, worked the same as the other code.

Diff Detail

Repository

rP Phabricator

Branch

phortune5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16478
Build 21942: Run Core Tests
Build 21941: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2017, 5:00 PM

Harbormaster completed remote builds in B16478: Diff 42547.Apr 14 2017, 5:01 PM

chad accepted this revision.Apr 14 2017, 5:05 PM

This revision is now accepted and ready to land.Apr 14 2017, 5:05 PM

Closed by commit rP7fbb5f2d9210: Reduce some code duplication in PhortuneLandingController (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

controller/

PhortuneLandingController.php

14 lines

Diff 42547

View Options

src/applications/phortune/controller/PhortuneLandingController.php

Reduce some code duplication in PhortuneLandingControllerClosedPublicActions