To get the current transaction PHID, you can do something like this on ModularTransactionType:

final protected function getCurrentTransactionPHID(() {
  $xaction_phid = $this->getStorage()->getPHID();
  if (!$xaction_phid) {
    throw new Exception(pht('Current transaction does not yet have a PHID yet!'));
  }
  return $xaction_phid;
}

It's possible that will throw. If it does, you can do this instead:

final protected function getCurrentTransactionPHID(() {
  $storage = $this->getStorage();
  
  $xaction_phid = $storage->getPHID();
  if (!$xaction_phid) {
    $xaction_phid = $storage->generatePHID();
    $storage->setPHID($xaction_phid);
  }
  
  return $xaction_phid;
}

That's a bit more magic but I think it's still OK and should work.

As written, I think this change breaks all the rendering of historic transactions? It also doesn't support the '=' action, which is OK for now, but if it's later exposed via EditEngine the controls there will think that = is supported.

Possibly better is:

• Keep oldValue as a list of old participants.
• Keep newValue as a list of new participants.
• Put a method on ModularTransactionType that calls $this->getEditor()->getPHIDTransactionNewValue() to make the method callable from ModularTransactions and handle converting - / + / = into a list of PHIDs.
• Use it to generate a list of PHIDs for the newValue.
• Keep applyExternalEffects, getTitle() and validateTransactions() based around lists of PHIDs.

This should also handle cases like array('-' => array('A'), '+' => array('A')) (adding and removing the same user in one transaction) correctly, but I think the current code has less-ideal handling of these weird edge cases.

EXCEPTION: (Error) Call to a member function generatePHID() on null at [<phabricator>/src/applications/transactions/storage/PhabricatorModularTransactionType.php:315]

Seems like getStorage is null here.

This is getting pretty far into sketchy territory but you could do this, in PhabricatorApplicationTransactionEditor->applyExternalEffects():

    $xtype = $this->getModularTransactionType($type);
    if ($xtype) {
+     $xtype = clone $xtype;
+     $xtype->setStorage($xaction);
      return $xtype->applyExternalEffects($object, $xaction->getNewValue());
    }

Or just leave this as PHID-VOID-0000 now and I'll counter-diff you some less questionable version of this after it lands?

I think we overwrite this PHID anyway in applyFinalEffects.

Yeah my sneaky plan for a good version of this is like:

• Set it to null here or something like that.
• If it's null when we get to applyFinalEffects(), always set it to the last transaction PHID.

Not sure if that'd work but then we wouldn't have to do anything fancy here.

"good"

Well, less sketchy.

getPHIDTransactionNewValue takes a transaction, which.... still having problems getting

I'll upload what I have but Im stuck

im ded

I don't really know what applyFinalEffects() is actually doing so I probably need to go look at the code a bit before I can fix that, but I think the bits other than that sorta work.

It updates the participants that they have a new unseen message

Somewhat works? Gotta go get a pupper.

Did you retrieve pupper at least?

Yes! I found a very nice pupper at a bargain rate!