Paths

Table of Contentst

Differential D17632

Rename "PhabricatorHash::digest()" to "weakDigest()"
ClosedPublic
Actions

Authored by epriestley on Apr 6 2017, 5:10 PM.

Details

Reviewers

chad

Maniphest Tasks

T12509: Plan the path forward from HMAC-SHA1

Commits

rP3d816e94dfbe: Rename "PhabricatorHash::digest()" to "weakDigest()"

Summary

Ref T12509. This encourages code to move away from HMAC+SHA1 by making the method name more obviously undesirable.

Test Plan

grep, browsed around.

Diff Detail

Repository

rP Phabricator

Branch

files23

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16332
Build 21717: Run Core Tests
Build 21716: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 6 2017, 5:10 PM

Harbormaster completed remote builds in B16332: Diff 42403.Apr 6 2017, 5:11 PM

chad accepted this revision.Apr 6 2017, 6:22 PM

This revision is now accepted and ready to land.Apr 6 2017, 6:22 PM

Closed by commit rP3d816e94dfbe: Rename "PhabricatorHash::digest()" to "weakDigest()" (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2017, 10:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

patches/

20130530.sessionhash.php

2 lines

src/

applications/

auth/

controller/

PhabricatorAuthController.php

2 lines

PhabricatorAuthLoginController.php

2 lines

PhabricatorAuthOneTimeLoginController.php

2 lines

PhabricatorAuthTerminateSessionController.php

2 lines

engine/

PhabricatorAuthSessionEngine.php

8 lines

factor/

PhabricatorTOTPAuthFactor.php

4 lines

provider/

PhabricatorAuthProvider.php

2 lines

query/

PhabricatorAuthSessionQuery.php

2 lines

base/

controller/

PhabricatorController.php

2 lines

celerity/

resources/

CelerityResources.php

2 lines

config/

check/

PhabricatorPathSetupCheck.php

2 lines

diffusion/

controller/

DiffusionServeController.php

2 lines

gitlfs/

DiffusionGitLFSTemporaryTokenType.php

2 lines

files/

engine/

PhabricatorChunkedFileStorageEngine.php

2 lines

metamta/

receiver/

PhabricatorObjectMailReceiver.php

2 lines

people/

storage/

PhabricatorUser.php

6 lines

settings/

panel/

PhabricatorPasswordSettingsPanel.php

2 lines

PhabricatorSessionsSettingsPanel.php

2 lines

infrastructure/

util/

PhabricatorHash.php

9 lines

Diff 42403

View Options

resources/sql/patches/20130530.sessionhash.php

View Options

src/applications/auth/controller/PhabricatorAuthController.php

View Options

src/applications/auth/controller/PhabricatorAuthLoginController.php

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

View Options

src/applications/auth/controller/PhabricatorAuthTerminateSessionController.php

View Options

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

View Options

src/applications/auth/query/PhabricatorAuthSessionQuery.php

View Options

src/applications/base/controller/PhabricatorController.php

View Options

src/applications/celerity/resources/CelerityResources.php

View Options

src/applications/config/check/PhabricatorPathSetupCheck.php

View Options

src/applications/diffusion/controller/DiffusionServeController.php

View Options

src/applications/diffusion/gitlfs/DiffusionGitLFSTemporaryTokenType.php

View Options

src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php

View Options

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

View Options

src/applications/people/storage/PhabricatorUser.php

View Options

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

View Options

src/infrastructure/util/PhabricatorHash.php

Rename "PhabricatorHash::digest()" to "weakDigest()"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42403

resources/sql/patches/20130530.sessionhash.php

src/applications/auth/controller/PhabricatorAuthController.php

src/applications/auth/controller/PhabricatorAuthLoginController.php

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

src/applications/auth/controller/PhabricatorAuthTerminateSessionController.php

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

src/applications/auth/provider/PhabricatorAuthProvider.php

src/applications/auth/query/PhabricatorAuthSessionQuery.php

src/applications/base/controller/PhabricatorController.php

src/applications/celerity/resources/CelerityResources.php

src/applications/config/check/PhabricatorPathSetupCheck.php

src/applications/diffusion/controller/DiffusionServeController.php

src/applications/diffusion/gitlfs/DiffusionGitLFSTemporaryTokenType.php

src/applications/files/engine/PhabricatorChunkedFileStorageEngine.php

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

src/applications/people/storage/PhabricatorUser.php

src/applications/settings/panel/PhabricatorPasswordSettingsPanel.php

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

src/infrastructure/util/PhabricatorHash.php

Rename "PhabricatorHash::digest()" to "weakDigest()"
ClosedPublic
Actions

Revision Contents
Changeset List