Page MenuHomePhabricator
Differential D17622

Upgrade "arc upload" to use SHA256
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 10:54 PM.
Tags
None
Referenced Files
F13086859: D17622.diff
Thu, Apr 25, 12:45 AM
Unknown Object (File)
Fri, Apr 19, 6:21 PM
Unknown Object (File)
Sun, Apr 7, 2:50 AM
Unknown Object (File)
Sat, Apr 6, 11:59 PM
Unknown Object (File)
Fri, Apr 5, 2:13 PM
Unknown Object (File)
Fri, Apr 5, 1:59 PM
Unknown Object (File)
Fri, Apr 5, 1:53 PM
Unknown Object (File)
Fri, Apr 5, 11:30 AM
View All 93 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12464: Move away from SHA1 in Files
Commits
rARC3512c4ab86d6: (stable) Promote 2017 Week 14
rARCa59cfca5f190: Upgrade "arc upload" to use SHA256
Summary

Fixes T12464. Moves "arc upload" to SHA256 where applicable.

Test Plan

Ran arc upload against a server with D17620 twice, saw it skip the actual upload the second time.

Diff Detail

Repository
rARC Arcanist
Branch
files12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16301
Build 21675: Run Core Tests
Build 21674: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 4 2017, 10:54 PM
Harbormaster completed remote builds in B16301: Diff 42374.Apr 4 2017, 10:55 PM
chad accepted this revision.Apr 4 2017, 11:40 PM
This revision is now accepted and ready to land.Apr 4 2017, 11:40 PM
Closed by commit rARCa59cfca5f190: Upgrade "arc upload" to use SHA256 (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2017, 11:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
upload/
16 lines

Diff 42374

View Options

src/upload/ArcanistFileDataRef.php

Loading...
Phabricator · Built by Phacility