Scope syntax css rules to direct descendants only in diffs
ClosedPublic
Actions

Authored by chad on Mar 27 2017, 5:24 PM.

Tags

None

Referenced Files

	F18824739: D17565.diff
	Thu, Oct 23, 5:41 PM

	F18770904: D17565.id42256.diff
	Wed, Oct 8, 4:03 PM

	F18625891: D17565.id42256.diff
	Sep 15 2025, 11:51 PM

	F18470791: D17565.diff
	Sep 2 2025, 6:28 PM

	F18230055: D17565.diff
	Aug 20 2025, 11:56 AM

	F18099410: D17565.id.diff
	Aug 9 2025, 4:41 AM

	F18098331: D17565.id42257.diff
	Aug 8 2025, 7:36 PM

	F18097659: D17565.diff
	Aug 8 2025, 2:52 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T11641: The at-mention of a disabled user renders a line instead of a dot for inline comments

Commits

rP9e2ab4f80e8c: Scope syntax css rules to direct descendants only in diffs

Summary

Fixes T11641. We're overbroad here (and this may need more scoping?) but this seems to resolve the immediate issue.

Test Plan

Upload a few diffs and ask disabled accounts to comment on them inline.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 27 2017, 5:24 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 27 2017, 5:24 PM

epriestley accepted this revision.Mar 27 2017, 5:25 PM

This revision is now accepted and ready to land.Mar 27 2017, 5:25 PM

Harbormaster completed remote builds in B16181: Diff 42256.Mar 27 2017, 5:25 PM

Closed by commit rP9e2ab4f80e8c: Scope syntax css rules to direct descendants only in diffs (authored by chad, committed by chad). · Explain WhyMar 27 2017, 5:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

css/

core/

syntax.css

2 lines

Diff 42257

View Options

resources/celerity/map.php