Page MenuHomePhabricator

Provide PhabricatorEnv::isSelfURI to test if a URI points at the current install
ClosedPublic

Authored by epriestley on Mar 16 2017, 1:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 3:43 AM
Unknown Object (File)
Sun, Nov 17, 11:48 AM
Unknown Object (File)
Sat, Nov 9, 1:10 PM
Unknown Object (File)
Sun, Oct 27, 9:19 PM
Unknown Object (File)
Sat, Oct 26, 9:25 AM
Unknown Object (File)
Wed, Oct 23, 11:38 AM
Unknown Object (File)
Oct 20 2024, 1:26 PM
Unknown Object (File)
Oct 18 2024, 7:54 PM
Subscribers
None

Details

Summary

Ref T5378. This repackages an existing check to see if a URI is a URI for the current install into a more reasonable form.

In an upcoming change, I'll use this new check to test whether http://example.whatever.com/T123 is a link to a task on the current install or not.

Test Plan

This stuff has good test coverage already; added some more.

Diff Detail

Repository
rP Phabricator
Branch
uri1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15995
Build 21203: Run Core Tests
Build 21202: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 16 2017, 3:33 AM

This doesn't really do anything on its own and I'm not sure what the fate of T5378 is, but the code is much cleaner and this change has a pile of unit tests, so I'm going to land it on quality grounds even though it doesn't really do anything for us yet.

This revision was automatically updated to reflect the committed changes.