Stronger scoping for Conpherence chat forms
ClosedPublic
Actions

Authored by chad on Mar 13 2017, 9:41 PM.

Details

Reviewers

Maniphest Tasks

T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence

Commits

rP81675e3302a2: Stronger scoping for Conpherence chat forms

Summary

Fixes T12391. Adds better scoping to these rules to contain changes to just Conpherence.

Test Plan

Test Conpherence, Task comment, persistent chat on mobile / desktop.

Diff Detail

Repository

rP Phabricator

Branch

conph-remarkup-scope (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15978
Build 21173: Run Core Tests
Build 21172: arc lint + arc unit

Event Timeline

chad created this revision.Mar 13 2017, 9:41 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 13 2017, 9:41 PM

Harbormaster completed remote builds in B15978: Diff 42071.Mar 13 2017, 9:42 PM

Thanks!

This revision is now accepted and ready to land.Mar 13 2017, 9:42 PM

Closed by commit rP81675e3302a2: Stronger scoping for Conpherence chat forms (authored by chad, committed by chad). · Explain WhyMar 14 2017, 1:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

conpherence/

message-pane.css

11 lines

Diff 42071

View Options

resources/celerity/map.php