Differential D17486

Use text ellipsis on hovercard tags
ClosedPublic
Actions

Authored by chad on Mar 9 2017, 7:06 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T12326: Long tag names can break out of hovercards

Commits

rP3277d8b8c822: Use text ellipsis on hovercard tags

Summary

Fixes T12326. Users can make really log tag titles, this forces ellipsis if it is too long.

Test Plan

Write a super long tag, see ellipisis. Test a small tag, see normal layout.

Diff Detail

Repository

rP Phabricator

Branch

hovercard-title (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15956
Build 21139: Run Core Tests
Build 21138: arc lint + arc unit

Event Timeline

chad created this revision.Mar 9 2017, 7:06 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 9 2017, 7:06 PM

Harbormaster completed remote builds in B15956: Diff 42050.Mar 9 2017, 7:07 PM

epriestley accepted this revision.Mar 9 2017, 7:08 PM

This revision is now accepted and ready to land.Mar 9 2017, 7:08 PM

Closed by commit rP3277d8b8c822: Use text ellipsis on hovercard tags (authored by chad, committed by chad). · Explain WhyMar 9 2017, 7:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

project/

project-card-view.css

8 lines

Diff 42050

View Options

resources/celerity/map.php