Paths

Table of Contentst

Differential D17418

Add an avatar builtin file generator
ClosedPublic
Actions

Authored by chad on Feb 27 2017, 4:40 AM.

Tags

None

Subscribers

Tokens

"Like" token, awarded by avivey.

Details

Reviewers

Maniphest Tasks

T10319: Generate unique? profile images for each new user

Commits

rP05377bea193c: Add an avatar builtin file generator

Summary

Ref T10319. This builds out a reasonably decent avatar generator. 256 colors x 74 images x 2 borders, 38k options. Not completely sure though how names disburse though, so likely half that number. I can add lowercase lettering to double the footprint if needed though.

Test Plan

UIExamples. Color generator here: http://tools.medialab.sciences-po.fr/iwanthue/

pasted_file (1×2 px, 636 KB)

Diff Detail

Repository

Branch

ui-example-generated-photos (branched from master)

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php:59	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 15788
Build 20874: Run Core Tests
Build 20873: arc lint + arc unit

Event Timeline

chad created this revision.Feb 27 2017, 4:40 AM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 27 2017, 4:40 AM

chad edited the test plan for this revision. (Show Details)Feb 27 2017, 4:41 AM

Harbormaster completed remote builds in B15788: Diff 41887.Feb 27 2017, 4:41 AM

avivey awarded a token.Feb 27 2017, 9:36 AM

epriestley accepted this revision.Feb 27 2017, 11:43 AM

epriestley added inline comments.

src/applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php
43–60	This should use `FileFinder` to search the directory recursively instead of hard-coding multiple paths.

This revision is now accepted and ready to land.Feb 27 2017, 11:43 AM

chad edited the test plan for this revision. (Show Details)Feb 27 2017, 3:40 PM

re-work with FileFinder

Harbormaster completed remote builds in B15805: Diff 41904.Feb 27 2017, 7:08 PM

Closed by commit rP05377bea193c: Add an avatar builtin file generator (authored by chad, committed by chad). · Explain WhyFeb 27 2017, 7:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

builtin/

alphanumeric/

src/

__phutil_library_map__.php

4 lines

applications/

files/

builtin/

PhabricatorFilesComposeAvatarBuiltinFile.php

425 lines

PhabricatorFilesOnDiskBuiltinFile.php

14 lines

uiexample/

examples/

PHUIProfileImageExample.php

77 lines

Diff 41887

resources/builtin/alphanumeric/0.png

Loading...

resources/builtin/alphanumeric/0d.png

Loading...

resources/builtin/alphanumeric/1.png

Loading...

resources/builtin/alphanumeric/1d.png

Loading...

resources/builtin/alphanumeric/2.png

Loading...

resources/builtin/alphanumeric/2d.png

Loading...

resources/builtin/alphanumeric/3.png

Loading...

resources/builtin/alphanumeric/3d.png

Loading...

resources/builtin/alphanumeric/4.png

Loading...

resources/builtin/alphanumeric/4d.png

Loading...

resources/builtin/alphanumeric/5.png

Loading...

resources/builtin/alphanumeric/5d.png

Loading...

resources/builtin/alphanumeric/6.png

Loading...

resources/builtin/alphanumeric/6d.png

Loading...

resources/builtin/alphanumeric/7.png

Loading...

resources/builtin/alphanumeric/7d.png

Loading...

resources/builtin/alphanumeric/8.png

Loading...

resources/builtin/alphanumeric/8d.png

Loading...

resources/builtin/alphanumeric/9.png

Loading...

resources/builtin/alphanumeric/9d.png

Loading...

resources/builtin/alphanumeric/A.png

Loading...

resources/builtin/alphanumeric/Ad.png

Loading...

resources/builtin/alphanumeric/B.png

Loading...

resources/builtin/alphanumeric/Bd.png

Loading...

resources/builtin/alphanumeric/C.png

Loading...

resources/builtin/alphanumeric/Cd.png

Loading...

resources/builtin/alphanumeric/D.png

Loading...

resources/builtin/alphanumeric/Dd.png

Loading...

resources/builtin/alphanumeric/E.png

Loading...

resources/builtin/alphanumeric/Ed.png

Loading...

resources/builtin/alphanumeric/F.png

Loading...

resources/builtin/alphanumeric/Fd.png

Loading...

resources/builtin/alphanumeric/G.png

Loading...

resources/builtin/alphanumeric/Gd.png

Loading...

resources/builtin/alphanumeric/H.png

Loading...

resources/builtin/alphanumeric/Hd.png

Loading...

resources/builtin/alphanumeric/I.png

Loading...

resources/builtin/alphanumeric/Id.png

Loading...

resources/builtin/alphanumeric/J.png

Loading...

resources/builtin/alphanumeric/Jd.png

Loading...

resources/builtin/alphanumeric/K.png

Loading...

resources/builtin/alphanumeric/Kd.png

Loading...

resources/builtin/alphanumeric/L.png

Loading...

resources/builtin/alphanumeric/Ld.png

Loading...

resources/builtin/alphanumeric/M.png

Loading...

resources/builtin/alphanumeric/Md.png

Loading...

resources/builtin/alphanumeric/N.png

Loading...

resources/builtin/alphanumeric/Nd.png

Loading...

resources/builtin/alphanumeric/O.png

Loading...

resources/builtin/alphanumeric/Od.png

Loading...

resources/builtin/alphanumeric/P.png

Loading...

resources/builtin/alphanumeric/Pd.png

Loading...

resources/builtin/alphanumeric/Q.png

Loading...

resources/builtin/alphanumeric/Qd.png

Loading...

resources/builtin/alphanumeric/R.png

Loading...

resources/builtin/alphanumeric/Rd.png

Loading...

resources/builtin/alphanumeric/S.png

Loading...

resources/builtin/alphanumeric/Sd.png

Loading...

resources/builtin/alphanumeric/Shrug.png

Loading...

resources/builtin/alphanumeric/Shrug2.png

Loading...

resources/builtin/alphanumeric/T.png

Loading...

resources/builtin/alphanumeric/Td.png

Loading...

resources/builtin/alphanumeric/U.png

Loading...

resources/builtin/alphanumeric/Ud.png

Loading...

resources/builtin/alphanumeric/V.png

Loading...

resources/builtin/alphanumeric/Vd.png

Loading...

resources/builtin/alphanumeric/W.png

Loading...

resources/builtin/alphanumeric/Wd.png

Loading...

resources/builtin/alphanumeric/X.png

Loading...

resources/builtin/alphanumeric/Xd.png

Loading...

resources/builtin/alphanumeric/Y.png

Loading...

resources/builtin/alphanumeric/Yd.png

Loading...

resources/builtin/alphanumeric/Z.png

Loading...

resources/builtin/alphanumeric/Zd.png

Loading...

resources/builtin/alphanumeric/shrug.png

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php

Loading...

src/applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php

Loading...

src/applications/uiexample/examples/PHUIProfileImageExample.php

Loading...