Page MenuHomePhabricator

Limit damage caused by bad panels on dashboards you can manage
ClosedPublic

Authored by epriestley on Feb 4 2017, 2:33 AM.
Tags
None
Referenced Files
F15466279: D17311.id41634.diff
Thu, Apr 3, 3:49 AM
F15454400: D17311.id.diff
Sat, Mar 29, 6:22 PM
F15450921: D17311.diff
Fri, Mar 28, 7:05 PM
F15427222: D17311.id41634.diff
Sun, Mar 23, 1:22 PM
F15424807: D17311.diff
Sun, Mar 23, 12:22 AM
F15380996: D17311.diff
Fri, Mar 14, 5:23 AM
Unknown Object (File)
Mar 3 2025, 5:28 PM
Unknown Object (File)
Mar 2 2025, 2:40 PM
Subscribers
None

Details

Summary

Fixes T12203. If you tried to manage a dashboard which had a panel you can't see, we'd try to render bogus actions for it and fatal.

Instead, for the moment, survive. Presumably we'll ship a real fix for this in the next release or so, and tackle T10612 / T10145, which I think are closely related.

Test Plan

Screen Shot 2017-02-03 at 6.31.21 PM.png (959×1 px, 160 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable