Add some style to label in Favorites Menu
ClosedPublic
Actions

Authored by chad on Feb 1 2017, 3:50 AM.

Tags

None

Referenced Files

	F15459587: D17285.id41580.diff
	Mon, Mar 31, 2:24 PM

	F15459100: D17285.id41584.diff
	Mon, Mar 31, 9:49 AM

	F15458951: D17285.diff
	Mon, Mar 31, 8:34 AM

	F15457138: D17285.id.diff
	Sun, Mar 30, 2:33 PM

	F15453959: D17285.diff
	Sat, Mar 29, 3:21 PM

	F15433246: D17285.id41584.diff
	Mon, Mar 24, 10:16 PM

	F15432140: D17285.diff
	Mon, Mar 24, 4:22 PM

	F15397021: D17285.id41584.diff
	Mar 16 2025, 5:43 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP7fc8e1978675: Add some style to label in Favorites Menu

Summary

Ref T12174. Always sets the correct type when converting to ActionList, adds a type to Divider.

Test Plan

Add a Label, 2 applications to the personal favorites menu, see nice styles.

Diff Detail

Repository

rP Phabricator

Branch

label-favorites (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15478
Build 20400: Run Core Tests
Build 20399: arc lint + arc unit

Event Timeline

chad created this revision.Feb 1 2017, 3:50 AM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 1 2017, 3:50 AM

Harbormaster completed remote builds in B15478: Diff 41580.Feb 1 2017, 3:51 AM

chad edited the test plan for this revision. (Show Details)Feb 1 2017, 3:52 AM

epriestley accepted this revision.Feb 1 2017, 1:28 PM

This revision is now accepted and ready to land.Feb 1 2017, 1:28 PM

Closed by commit rP7fc8e1978675: Add some style to label in Favorites Menu (authored by chad, committed by chad). · Explain WhyFeb 1 2017, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

favorites/

engineextension/

PhabricatorFavoritesMainMenuBarExtension.php

6 lines

search/

menuitem/

PhabricatorDividerProfileMenuItem.php

1 line

Diff 41580

View Options

src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php