Differential D17284

Fix application name toolip hover
ClosedPublic
Actions

Authored by chad on Feb 1 2017, 3:36 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP113bdd9f7940: Fix application name toolip hover

Summary

Ref T12174. We were always setting a name via builtins so the tooltip was always set. Fix the calls here.

Test Plan

Add "Badges", see tooltip, give "Badges" a name of "Badges", don't see tooltip.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 1 2017, 3:36 AM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 1 2017, 3:36 AM

Harbormaster completed remote builds in B15477: Diff 41579.Feb 1 2017, 3:37 AM

epriestley accepted this revision.Feb 1 2017, 1:28 PM

This revision is now accepted and ready to land.Feb 1 2017, 1:28 PM

Closed by commit rP113bdd9f7940: Fix application name toolip hover (authored by chad, committed by chad). · Explain WhyFeb 1 2017, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

home/

engine/

PhabricatorHomeProfileMenuEngine.php

2 lines

search/

menuitem/

PhabricatorApplicationProfileMenuItem.php

3 lines

Diff 41585

View Options

src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php