Paths

Table of Contentst

Add Label MenuItem
ClosedPublic
Actions

Authored by chad on Jan 31 2017, 9:06 PM.

Tags

None

Referenced Files

	F14230681: D17278.diff
	Wed, Dec 11, 9:27 PM

	Unknown Object (File)
	Mon, Dec 9, 7:54 PM

	Unknown Object (File)
	Wed, Nov 27, 3:07 AM

	Unknown Object (File)
	Sat, Nov 23, 2:45 PM

	Unknown Object (File)
	Fri, Nov 22, 11:52 PM

	Unknown Object (File)
	Tue, Nov 19, 3:48 AM

	Unknown Object (File)
	Fri, Nov 15, 1:56 PM

	Unknown Object (File)
	Nov 11 2024, 7:20 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12174: Home Menu Errata

Commits

rPf7c381358656: Add Label MenuItem

Summary

Ref T12174, lets you set labels as well for dividing content.

Test Plan

Add a label, review on homepage.

Diff Detail

Repository

rP Phabricator

Branch

label-menu-item (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15463
Build 20377: Run Core Tests
Build 20376: arc lint + arc unit

Event Timeline

chad created this revision.Jan 31 2017, 9:06 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 31 2017, 9:06 PM

getLinkName() is a sort of odd name for a label which isn't a link, maybe getLabelName()?

This revision is now accepted and ready to land.Jan 31 2017, 9:07 PM

Harbormaster completed remote builds in B15463: Diff 41565.Jan 31 2017, 9:07 PM

copypasta

Closed by commit rPf7c381358656: Add Label MenuItem (authored by chad, committed by chad). · Explain WhyJan 31 2017, 9:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

search/

menuitem/

PhabricatorLabelProfileMenuItem.php

75 lines

Diff 41565

View Options

src/__phutil_library_map__.php