Page MenuHomePhabricator

Replace ProfileMenu bugs with different bugs
ClosedPublic

Authored by epriestley on Jan 31 2017, 7:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 9:39 AM
Unknown Object (File)
Wed, Dec 4, 9:10 AM
Unknown Object (File)
Tue, Dec 3, 11:28 PM
Unknown Object (File)
Nov 11 2024, 6:16 AM
Unknown Object (File)
Oct 31 2024, 6:50 AM
Unknown Object (File)
Oct 29 2024, 2:56 PM
Unknown Object (File)
Oct 24 2024, 11:58 AM
Unknown Object (File)
Oct 18 2024, 3:04 PM
Subscribers
None

Details

Summary

Ref T12174. This fixes more bugs than it creates, I think:

  • Dashboards now show the whole menu.
  • Project and home items now show selected state correctly.
  • The "choose global vs personal" thing is now part of MenuEngine, and the same code builds it for Home and Favorites.
  • Home now handles defaults correctly, I think.

Maybe regression/bad/still buggy?:

  • Mobile home is now whatever the default thing was, not the menu?
  • Title for dashboard content or other items that render their own content is incorrectly always "Configure Menu" (this was preexisting).
Test Plan
  • Created, edited, reordered, disabled, deleted and pinned personal and global items on home, favorites, and projects.
  • Also checked User profiles.

Diff Detail

Repository
rP Phabricator
Branch
home2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/search/engine/PhabricatorProfileMenuEngine.php:289XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15453
Build 20361: Run Core Tests
Build 20360: arc lint + arc unit

Event Timeline

Will this support Global / Personal for projects to? That would have "Global" be things applied to all projects, and "Personal" being just that project. However these only seem useful if we can pass in projectPHID to alter what the Global link does...

I dont know we'll do that, just spitballing....

This revision is now accepted and ready to land.Jan 31 2017, 7:18 PM
src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php
10–12

It keeps projects as-is because of this, which turns off the "personal/custom" option.

Overall, this probably moves us slightly closer to a per-project vs all-projects mode but doesn't get us there, the "custom/personal" mode is still fairly specific to being a personal-per-viewer mode.

This revision was automatically updated to reflect the committed changes.

I'm going to deploy this now and we can see how bad I am at testing.