Remove an unused method in Audit for building comment actions
ClosedPublic
Actions

Authored by epriestley on Jan 25 2017, 7:27 PM.

Tags

None

Referenced Files

	F15427398: D17249.id.diff
	Sun, Mar 23, 2:11 PM

	F15374990: D17249.diff
	Wed, Mar 12, 8:58 PM

	Unknown Object (File)
	Sun, Feb 23, 10:54 AM

	Unknown Object (File)
	Feb 21 2025, 3:08 PM

	Unknown Object (File)
	Feb 9 2025, 3:11 AM

	Unknown Object (File)
	Feb 9 2025, 3:11 AM

	Unknown Object (File)
	Feb 9 2025, 3:11 AM

	Unknown Object (File)
	Jan 28 2025, 2:11 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T2393: Adds a "Needs Verification" state to Audits

Commits

rP36d936fe8ae2: Remove an unused method in Audit for building comment actions

Summary

Ref T2393. This has been obsoleted by stacked actions and is no longer used.

Test Plan

Grepped for callsites, viwed commits.

Diff Detail

Repository

rP Phabricator

Branch

audit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15375
Build 20250: Run Core Tests
Build 20249: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 25 2017, 7:27 PM

chad accepted this revision.Jan 25 2017, 7:28 PM

This revision is now accepted and ready to land.Jan 25 2017, 7:28 PM

Harbormaster completed remote builds in B15375: Diff 41485.Jan 25 2017, 7:28 PM

Closed by commit rP36d936fe8ae2: Remove an unused method in Audit for building comment actions (authored by epriestley, committed by epriestley). · Explain WhyJan 25 2017, 9:07 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13631: Support an "auditors" attachment for "diffusion.commit.search".Mar 9 2021, 11:50 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionCommitController.php

79 lines

Diff 41485

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Remove an unused method in Audit for building comment actionsClosedPublicActions