diff --git a/src/applications/audit/view/PhabricatorAuditListView.php b/src/applications/audit/view/PhabricatorAuditListView.php --- a/src/applications/audit/view/PhabricatorAuditListView.php +++ b/src/applications/audit/view/PhabricatorAuditListView.php @@ -139,7 +139,9 @@ $item = id(new PHUIObjectItemView()) ->setObjectName($commit_name) ->setHeader($commit_desc) - ->setHref($commit_link); + ->setHref($commit_link) + ->addByline(pht('Author: %s', $author_name)) + ->addIcon('none', $committed); if ($show_drafts) { if ($commit->getHasDraft($viewer)) { @@ -147,20 +149,16 @@ } } - $item - ->addAttribute(pht('Author: %s', $author_name)) - ->addIcon('none', $committed); - $audits = $commit->getAudits(); $auditor_phids = mpull($audits, 'getAuditorPHID'); if ($auditor_phids) { - $item->addByLine( - array( - pht('Auditors:'), - ' ', - $handles->newSublist($auditor_phids)->renderList(), - )); + $auditor_list = $handles->newSublist($auditor_phids) + ->renderList() + ->setAsInline(true); + } else { + $auditor_list = phutil_tag('em', array(), pht('None')); } + $item->addAttribute(pht('Auditors: %s', $auditor_list)); if ($status_color) { $item->setStatusIcon($status_icon.' '.$status_color, $status_text); diff --git a/src/applications/diffusion/view/DiffusionHistoryTableView.php b/src/applications/diffusion/view/DiffusionHistoryTableView.php --- a/src/applications/diffusion/view/DiffusionHistoryTableView.php +++ b/src/applications/diffusion/view/DiffusionHistoryTableView.php @@ -187,6 +187,19 @@ 'type' => $history->getFileType(), )); + $status = $commit->getAuditStatus(); + $icon = PhabricatorAuditCommitStatusConstants::getStatusIcon($status); + $color = PhabricatorAuditCommitStatusConstants::getStatusColor($status); + $name = PhabricatorAuditCommitStatusConstants::getStatusName($status); + + $audit_view = id(new PHUIIconView()) + ->setIcon($icon, $color) + ->addSigil('has-tooltip') + ->setMetadata( + array( + 'tip' => $name, + )); + $rows[] = array( $graph ? $graph[$ii++] : null, $browse, @@ -194,6 +207,7 @@ $drequest->getRepository(), $history->getCommitIdentifier()), $build, + $audit_view, ($commit ? self::linkRevision(idx($this->revisions, $commit->getPHID())) : null), @@ -211,7 +225,8 @@ pht('Commit'), null, null, - pht('Author/Committer'), + null, + pht('Author'), pht('Details'), pht('Committed'), )); @@ -221,6 +236,7 @@ 'nudgeright', '', 'icon', + 'icon', '', '', 'wide', @@ -232,6 +248,7 @@ true, true, $has_any_build, + true, $show_revisions, )); $view->setDeviceVisibility( @@ -241,6 +258,7 @@ true, true, true, + true, false, true, false,