Change PHP 7 setup warning to complain about 7.0 only, not 7.1+
ClosedPublic
Actions

Authored by epriestley on Jan 12 2017, 11:41 PM.

Tags

None

Referenced Files

	F15471600: D17197.id41350.diff
	Sat, Apr 5, 6:15 AM

	F15446646: D17197.id41357.diff
	Thu, Mar 27, 7:39 PM

	F15445985: D17197.id41357.diff
	Thu, Mar 27, 4:54 PM

	F15442550: D17197.id41350.diff
	Wed, Mar 26, 11:48 PM

	F15442549: D17197.id.diff
	Wed, Mar 26, 11:47 PM

	F15442547: D17197.diff
	Wed, Mar 26, 11:47 PM

	F15437304: D17197.id41350.diff
	Tue, Mar 25, 6:50 PM

	F15430856: D17197.id.diff
	Mon, Mar 24, 9:18 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9640: Make Phabricator compatible with PHP7

Commits

rPa2cd3d9a8913: Change PHP 7 setup warning to complain about 7.0 only, not 7.1+

Summary

Ref T9640. On 7.0 we had signal handling issues so we can never support it, but async signals should resolve them on 7.1 or newer.

Test Plan

On PHP 7.1, got through the setup warning.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 12 2017, 11:41 PM

Harbormaster completed remote builds in B15238: Diff 41350.Jan 12 2017, 11:42 PM

chad accepted this revision.Jan 12 2017, 11:42 PM

This revision is now accepted and ready to land.Jan 12 2017, 11:42 PM

Closed by commit rPa2cd3d9a8913: Change PHP 7 setup warning to complain about 7.0 only, not 7.1+ (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2017, 11:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorPHPPreflightSetupCheck.php

9 lines

Diff 41357

View Options

src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php

Change PHP 7 setup warning to complain about 7.0 only, not 7.1+ClosedPublicActions