Page MenuHomePhabricator

Draw project PHIDs from repositories when evaluating Herald object rules for commits
ClosedPublic

Authored by epriestley on Jan 11 2017, 6:13 PM.
Tags
None
Referenced Files
F18140200: D17179.id41312.diff
Thu, Aug 14, 3:43 AM
F17943316: D17179.id.diff
Jul 31 2025, 8:08 AM
F17926693: D17179.diff
Jul 30 2025, 1:32 PM
F17648923: D17179.id41311.diff
Jul 12 2025, 3:04 AM
Unknown Object (File)
Jun 18 2025, 9:45 AM
Unknown Object (File)
Jun 16 2025, 12:55 AM
Unknown Object (File)
Jun 4 2025, 6:19 AM
Unknown Object (File)
May 29 2025, 8:57 AM
Subscribers
None

Details

Summary

Fixes T12097. In D16413, I simplified this code but caused us to load the commit's projects instead of the repository's projects, which is incorrect.

Normally, commits don't have any project tags when Herald evaluates, so using the commit's projects is generally meaningless.

Test Plan
  • Tagged a repository with #X.
  • Created a Herald object rule for commits with #X as the object ("Always ... do nothing.")
  • Ran a commit from the repository.
  • Before patch: rule failed to evaluate.
  • After patch: rule evaluated and passed.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15198
Build 19973: Run Core Tests
Build 19972: arc lint + arc unit