Page MenuHomePhabricator
Differential D17179

Draw project PHIDs from repositories when evaluating Herald object rules for commits
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 4, 6:19 AM
Unknown Object (File)
Thu, May 29, 8:57 AM
Unknown Object (File)
Thu, May 29, 7:34 AM
Unknown Object (File)
Wed, May 28, 12:37 PM
Unknown Object (File)
May 7 2025, 2:42 AM
Unknown Object (File)
May 1 2025, 6:49 PM
Unknown Object (File)
Apr 28 2025, 8:02 AM
Unknown Object (File)
Apr 27 2025, 11:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12097: Object Herald Rules for Commits on Projects no longer working as expected
Commits
rPa27c824da67d: Draw project PHIDs from repositories when evaluating Herald object rules for…
Summary

Fixes T12097. In D16413, I simplified this code but caused us to load the commit's projects instead of the repository's projects, which is incorrect.

Normally, commits don't have any project tags when Herald evaluates, so using the commit's projects is generally meaningless.

Test Plan
  • Tagged a repository with #X.
  • Created a Herald object rule for commits with #X as the object ("Always ... do nothing.")
  • Ran a commit from the repository.
  • Before patch: rule failed to evaluate.
  • After patch: rule evaluated and passed.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15198
Build 19973: Run Core Tests
Build 19972: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
herald/
26 lines

Diff 41311

View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
Phabricator · Built by Phacility