Page MenuHomePhabricator

Draw project PHIDs from repositories when evaluating Herald object rules for commits
ClosedPublic

Authored by epriestley on Jan 11 2017, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 9:14 PM
Unknown Object (File)
Fri, Dec 6, 2:23 PM
Unknown Object (File)
Nov 30 2024, 9:22 PM
Unknown Object (File)
Nov 30 2024, 11:30 AM
Unknown Object (File)
Nov 30 2024, 4:25 AM
Unknown Object (File)
Nov 21 2024, 5:02 PM
Unknown Object (File)
Nov 21 2024, 4:04 PM
Unknown Object (File)
Nov 17 2024, 6:28 AM
Subscribers
None

Details

Summary

Fixes T12097. In D16413, I simplified this code but caused us to load the commit's projects instead of the repository's projects, which is incorrect.

Normally, commits don't have any project tags when Herald evaluates, so using the commit's projects is generally meaningless.

Test Plan
  • Tagged a repository with #X.
  • Created a Herald object rule for commits with #X as the object ("Always ... do nothing.")
  • Ran a commit from the repository.
  • Before patch: rule failed to evaluate.
  • After patch: rule evaluated and passed.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15198
Build 19973: Run Core Tests
Build 19972: arc lint + arc unit