Page MenuHomePhabricator

Bring very basic EditEngine support to commits
ClosedPublic

Authored by epriestley on Jan 11 2017, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 11:12 AM
Unknown Object (File)
Tue, Aug 13, 6:07 PM
Unknown Object (File)
Sun, Aug 11, 7:27 PM
Unknown Object (File)
Fri, Aug 9, 1:03 AM
Unknown Object (File)
Jul 30 2024, 7:24 PM
Unknown Object (File)
Jul 29 2024, 12:38 PM
Unknown Object (File)
Jul 20 2024, 1:02 AM
Unknown Object (File)
Jul 15 2024, 10:14 AM
Subscribers
None

Details

Summary

Ref T10978. After T11114, we have some features (like the old code for the haunted comment panel) which are only used by Diffusion. I want to modernize it so I can nuke them. T10978 also describes many bugs which are only fixable after modernizing.

This adds very basic EditEngine support for commits/audit. You can't create new commits with this workflow, just tag/update existing ones.

Test Plan

Screen Shot 2017-01-11 at 8.42.50 AM.png (1×2 px, 318 KB)

Diff Detail

Repository
rP Phabricator
Branch
commit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15193
Build 19964: Run Core Tests
Build 19963: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 11 2017, 4:58 PM
This revision was automatically updated to reflect the committed changes.