Page MenuHomePhabricator

Bring very basic EditEngine support to commits
ClosedPublic

Authored by epriestley on Jan 11 2017, 4:48 PM.
Tags
None
Referenced Files
F15398178: D17175.diff
Sun, Mar 16, 11:40 PM
F15385401: D17175.id41306.diff
Fri, Mar 14, 10:30 PM
Unknown Object (File)
Sun, Feb 23, 4:03 AM
Unknown Object (File)
Fri, Feb 21, 3:03 PM
Unknown Object (File)
Feb 13 2025, 7:40 AM
Unknown Object (File)
Feb 13 2025, 3:07 AM
Unknown Object (File)
Feb 11 2025, 9:14 PM
Unknown Object (File)
Feb 1 2025, 5:55 PM
Subscribers
None

Details

Summary

Ref T10978. After T11114, we have some features (like the old code for the haunted comment panel) which are only used by Diffusion. I want to modernize it so I can nuke them. T10978 also describes many bugs which are only fixable after modernizing.

This adds very basic EditEngine support for commits/audit. You can't create new commits with this workflow, just tag/update existing ones.

Test Plan

Screen Shot 2017-01-11 at 8.42.50 AM.png (1×2 px, 318 KB)

Diff Detail

Repository
rP Phabricator
Branch
commit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15193
Build 19964: Run Core Tests
Build 19963: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 11 2017, 4:58 PM
This revision was automatically updated to reflect the committed changes.