Make differential.querydiffs more liberal about arguments
ClosedPublic
Actions

Authored by epriestley on Jan 10 2017, 9:45 PM.

Details

Reviewers

chad

Maniphest Tasks

T12092: conduit.querydiffs generates error when optional `id` argument is empty

Commits

rP52d563f8b8cf: Make differential.querydiffs more liberal about arguments

Summary

Fixes T12092. D17164 made DiffQuery more strict about arguments using modern conventions, but differential.querydiffs uses bizarre ancient conventions.

Give it more modern conventions instead.

Test Plan

Made a querydiffs call with only revision IDs.

Diff Detail

Repository

rP Phabricator

Branch

conduit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15186
Build 19953: Run Core Tests
Build 19952: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 10 2017, 9:45 PM

chad accepted this revision.Jan 10 2017, 9:45 PM

This revision is now accepted and ready to land.Jan 10 2017, 9:45 PM

Harbormaster completed remote builds in B15186: Diff 41299.Jan 10 2017, 9:46 PM

Closed by commit rP52d563f8b8cf: Make differential.querydiffs more liberal about arguments (authored by epriestley, committed by epriestley). · Explain WhyJan 10 2017, 9:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialQueryDiffsConduitAPIMethod.php

27 lines

Diff 41299

View Options

src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php

Make differential.querydiffs more liberal about argumentsClosedPublicActions