Page MenuHomePhabricator

Make differential.querydiffs more liberal about arguments
ClosedPublic

Authored by epriestley on Jan 10 2017, 9:45 PM.
Tags
None
Referenced Files
F19641451: D17172.id.diff
Thu, Feb 5, 7:24 PM
F19524533: D17172.id41299.diff
Sun, Jan 18, 1:45 AM
F19509177: D17172.id41300.diff
Sat, Jan 10, 4:12 PM
F19499062: D17172.id41300.diff
Thu, Jan 8, 1:29 PM
F19371226: D17172.id41300.diff
Dec 26 2025, 4:30 PM
F19055005: D17172.diff
Nov 28 2025, 3:41 PM
F18823692: D17172.id.diff
Oct 23 2025, 12:58 PM
F18752561: D17172.id41299.diff
Oct 4 2025, 3:41 PM
Subscribers
None

Details

Summary

Fixes T12092. D17164 made DiffQuery more strict about arguments using modern conventions, but differential.querydiffs uses bizarre ancient conventions.

Give it more modern conventions instead.

Test Plan

Made a querydiffs call with only revision IDs.

Diff Detail

Repository
rP Phabricator
Branch
conduit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15186
Build 19953: Run Core Tests
Build 19952: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 10 2017, 9:45 PM
This revision was automatically updated to reflect the committed changes.