diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -494,7 +494,6 @@ 'DifferentialRevertPlanCommitMessageField' => 'applications/differential/field/DifferentialRevertPlanCommitMessageField.php', 'DifferentialRevertPlanField' => 'applications/differential/customfield/DifferentialRevertPlanField.php', 'DifferentialReviewedByCommitMessageField' => 'applications/differential/field/DifferentialReviewedByCommitMessageField.php', - 'DifferentialReviewedByField' => 'applications/differential/customfield/DifferentialReviewedByField.php', 'DifferentialReviewerDatasource' => 'applications/differential/typeahead/DifferentialReviewerDatasource.php', 'DifferentialReviewerForRevisionEdgeType' => 'applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php', 'DifferentialReviewerProxy' => 'applications/differential/storage/DifferentialReviewerProxy.php', @@ -5146,7 +5145,6 @@ 'DifferentialRevertPlanCommitMessageField' => 'DifferentialCommitMessageCustomField', 'DifferentialRevertPlanField' => 'DifferentialStoredCustomField', 'DifferentialReviewedByCommitMessageField' => 'DifferentialCommitMessageField', - 'DifferentialReviewedByField' => 'DifferentialCoreCustomField', 'DifferentialReviewerDatasource' => 'PhabricatorTypeaheadCompositeDatasource', 'DifferentialReviewerForRevisionEdgeType' => 'PhabricatorEdgeType', 'DifferentialReviewerProxy' => 'Phobject', diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php --- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php +++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php @@ -30,7 +30,6 @@ new DifferentialTestPlanField(), new DifferentialReviewersField(), new DifferentialProjectReviewersField(), - new DifferentialReviewedByField(), new DifferentialSubscribersField(), new DifferentialRepositoryField(), new DifferentialViewPolicyField(), diff --git a/src/applications/differential/customfield/DifferentialReviewedByField.php b/src/applications/differential/customfield/DifferentialReviewedByField.php deleted file mode 100644 --- a/src/applications/differential/customfield/DifferentialReviewedByField.php +++ /dev/null @@ -1,68 +0,0 @@ -getReviewerStatus() as $reviewer) { - switch ($reviewer->getStatus()) { - case DifferentialReviewerStatus::STATUS_ACCEPTED: - case DifferentialReviewerStatus::STATUS_ACCEPTED_OLDER: - $phids[] = $reviewer->getReviewerPHID(); - break; - } - } - - return $phids; - } - - public function shouldAppearInCommitMessage() { - return true; - } - - public function parseValueFromCommitMessage($value) { - return $this->parseObjectList( - $value, - array( - PhabricatorPeopleUserPHIDType::TYPECONST, - PhabricatorProjectProjectPHIDType::TYPECONST, - ), - $allow_partial = true); - } - - public function getRequiredHandlePHIDsForCommitMessage() { - return $this->getValue(); - } - - public function renderCommitMessageValue(array $handles) { - return $this->renderObjectList($handles); - } - -}