Page MenuHomePhabricator

Fix two cache issues (global settings; initial setup)
ClosedPublic

Authored by epriestley on Dec 11 2016, 3:17 PM.
Tags
None
Referenced Files
F13322040: D17024.diff
Fri, Jun 14, 7:31 AM
F13304960: D17024.id40951.diff
Sat, Jun 8, 3:12 PM
F13288125: D17024.diff
Tue, Jun 4, 9:50 AM
F13276104: D17024.diff
Fri, May 31, 5:33 AM
F13266207: D17024.id.diff
Tue, May 28, 10:33 AM
F13218980: D17024.id40952.diff
May 18 2024, 2:21 PM
F13215632: D17024.id40951.diff
May 17 2024, 6:45 PM
F13195624: D17024.diff
May 12 2024, 10:31 PM
Subscribers
None

Details

Summary
  • Fixes T11995. This got moved but I missed renaming this callsite.
  • Fixes T11993. If you have valid credentials, but haven't run storage upgrade yet, we can hit this exception during setup. Just ignore it instead.
Test Plan
  • Saved global settings, no more fatal.
  • Changed storage-namespace to junk, loaded web UI with valid database credentials.

Screen Shot 2016-12-11 at 7.15.09 AM.png (989×1 px, 79 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix two cache issues (global settings; initial setup).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2016, 3:29 PM
This revision was automatically updated to reflect the committed changes.