Page MenuHomePhabricator
Differential D17015

When rendering the "you were invited" header, query the inviting user with the omnipotent viewer
ClosedPublic
Actions

Authored by epriestley on Dec 9 2016, 4:22 PM.
Tags
None
Referenced Files
F17365072: D17015.diff
Sat, Jun 28, 1:30 PM
Unknown Object (File)
Fri, Jun 20, 10:46 AM
Unknown Object (File)
Fri, Jun 20, 7:02 AM
Unknown Object (File)
Thu, Jun 19, 6:15 AM
Unknown Object (File)
Wed, Jun 18, 1:45 PM
Unknown Object (File)
Tue, Jun 17, 3:37 PM
Unknown Object (File)
May 29 2025, 8:51 AM
Unknown Object (File)
May 5 2025, 7:01 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site
Commits
rP9c72c1b1daa9: When rendering the "you were invited" header, query the inviting user with the…
Summary

Fixes T11982. If an install is not public, the registering user may not be able to see the inviting user.

Test Plan

Screen Shot 2016-12-09 at 8.21.30 AM.png (767×1 px, 77 KB)

Diff Detail

Repository
rP Phabricator
Branch
invite2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14824
Build 19395: Run Core Tests
Build 19394: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40937.Dec 9 2016, 4:22 PM
epriestley retitled this revision from to When rendering the "you were invited" header, query the inviting user with the omnipotent viewer.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.
chad edited edge metadata.Dec 9 2016, 4:23 PM

Lol

epriestley added a comment.Dec 9 2016, 4:23 PM

ill lol u buddy

I think this is just rare -- private installs normally do open registration instead of inviting individual users.

chad accepted this revision.Dec 9 2016, 4:31 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2016, 4:31 PM
Closed by commit rP9c72c1b1daa9: When rendering the "you were invited" header, query the inviting user with the… (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2016, 4:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
6 lines

Diff 40937

View Options

src/applications/auth/controller/PhabricatorAuthController.php

Loading...
Phabricator · Built by Phacility