Add WP-like set_sql_mode to Aphront to avoid errors in managed SQL databases (such as AWS or GCE)
Needs ReviewPublic
Actions

Authored by egg82 on Dec 1 2016, 8:02 PM.

Details

Reviewers

None

Required Signatures

L28 Phacility Individual Contributor License Agreement

Test Plan

These additions may need to be moved or changed, but it would alleviate the "SQL mode" errors for the most part. Current plan is to review changes with someone more familiar with the higher-level framework than I am before rolling out to production.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

egg82 updated this revision to Diff 40841.Dec 1 2016, 8:02 PM

egg82 retitled this revision from to Add WP-like set_sql_mode to Aphront to avoid errors in managed SQL databases (such as AWS or GCE).

egg82 updated this object.

egg82 edited the test plan for this revision. (Show Details)

egg82 set the repository for this revision to rPHU libphutil.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2016, 8:02 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

See Contributing Code if this is intended for the upstream:

File a task with a bug report or feature request before you write code.

epriestley removed a reviewer: Blessed Reviewers.Dec 1 2016, 8:08 PM

epriestley removed a subscriber: epriestley.

egg82 mentioned this in T11937: GCloud SQL does not support configuring sql_mode.Dec 1 2016, 8:33 PM

• TweikerManager added a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:50 PM

epriestley removed a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:52 PM

Revision Contents
Changeset List

Path

Size

src/

aphront/

storage/

connection/

mysql/

AphrontMySQLDatabaseConnection.php

30 lines

AphrontMySQLiDatabaseConnection.php

34 lines

Diff 40841

View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php