Page MenuHomePhabricator

Improve PhutilConsole rendering support for ANSI escape sequences
ClosedPublic

Authored by epriestley on Nov 23 2016, 3:35 PM.
Tags
None
Referenced Files
F10892261: D16926.id40746.diff
Sun, Jul 3, 5:44 PM
F10892260: D16926.id40743.diff
Sun, Jul 3, 5:44 PM
F10892259: D16926.id.diff
Sun, Jul 3, 5:44 PM
F10892258: D16926.diff
Sun, Jul 3, 5:44 PM
Unknown Object (File)
Wed, Jun 29, 1:39 PM
Unknown Object (File)
Sun, Jun 26, 3:00 PM
Unknown Object (File)
Sun, Jun 26, 12:25 AM
Unknown Object (File)
Tue, Jun 21, 7:05 AM
Subscribers
None

Details

Summary

Ref T10895. Currently, if you try to pass tsprintf(...) to this stuff, it gets upset.

Support rendering PhutilTerminalString properly, with indenting/wrapping.

Test Plan

Wrote code with addParagraph(tsprintf(...)) and ran it, saw nice ANSI colors and formatting.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve PhutilConsole rendering support for ANSI escape sequences.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2016, 3:54 PM
This revision was automatically updated to reflect the committed changes.