Page MenuHomePhabricator
Differential D16913

Allow persistent connections to be configured per database host
ClosedPublic
Actions

Authored by epriestley on Nov 22 2016, 2:41 PM.
Tags
None
Referenced Files
F18857547: D16913.id.diff
Sat, Nov 1, 3:59 PM
F18851831: D16913.diff
Fri, Oct 31, 4:35 AM
F18773457: D16913.id40716.diff
Oct 9 2025, 10:06 AM
F18725124: D16913.diff
Sep 30 2025, 4:48 AM
F18705716: D16913.id.diff
Sep 28 2025, 12:46 PM
F18643522: D16913.id40725.diff
Sep 19 2025, 2:34 AM
F18608056: D16913.diff
Sep 14 2025, 12:49 AM
F18508306: D16913.id.diff
Sep 5 2025, 2:44 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11044: Support partitioning application databases across multiple database hosts
T11672: Evaluate persistent connections from HTTP contexts
Commits
rP8c89fc38fc42: Allow persistent connections to be configured per database host
Summary

Ref T11044. Fixes T11672. In T11672, persistent connections seem to work fine, but they can require max_connections and other settings to be raised. Since most users don't need them, make them an advanced option.

Test Plan

Configured persistent connections, loaded some pages, observed persistent connections get used.

Diff Detail

Repository
rP Phabricator
Branch
partition9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14614
Build 19079: Run Core Tests
Build 19078: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40716.Nov 22 2016, 2:41 PM
epriestley retitled this revision from to Allow persistent connections to be configured per database host.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11672: Evaluate persistent connections from HTTP contexts.
epriestley mentioned this in T11908: Support an "overlay" database connection mode where multiple applications share a single connection.Nov 22 2016, 2:54 PM
epriestley updated this object.
epriestley added a task: T11044: Support partitioning application databases across multiple database hosts.
epriestley updated this revision to Diff 40721.Nov 22 2016, 6:03 PM
  • Fix a documentation typo.
chad accepted this revision.Nov 22 2016, 6:11 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 6:11 PM
Closed by commit rP8c89fc38fc42: Allow persistent connections to be configured per database host (authored by epriestley, committed by epriestley). · Explain WhyNov 22 2016, 6:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40721

View Options

src/docs/user/cluster/cluster_partitioning.diviner

Loading...
View Options

src/infrastructure/cluster/PhabricatorClusterDatabasesConfigOptionType.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...
View Options

src/infrastructure/cluster/PhabricatorDatabaseRefParser.php

Loading...
View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Loading...
Phabricator · Built by Phacility