Page MenuHomePhabricator

Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks
ClosedPublic

Authored by epriestley on Nov 18 2016, 10:07 PM.
Tags
None
Referenced Files
F15280644: D16900.diff
Mon, Mar 3, 12:19 PM
Unknown Object (File)
Sat, Feb 22, 11:10 AM
Unknown Object (File)
Tue, Feb 18, 12:04 PM
Unknown Object (File)
Jan 31 2025, 5:56 PM
Unknown Object (File)
Jan 29 2025, 4:24 AM
Unknown Object (File)
Jan 22 2025, 5:42 AM
Unknown Object (File)
Jan 21 2025, 11:57 AM
Unknown Object (File)
Jan 17 2025, 7:25 PM
Subscribers
None

Details

Summary

Ref T8345. See T8345#201048 for discussion.

This rule (don't show mentions of or from restricted objects) is more consistent with how we render mentions in the timeline and I think generally a better behavior.

Test Plan
  • Mentioned a task on a public task and a private task.
  • Privileged user (foreground) sees both.
  • Public user (background) sees only the public mention.

Screen Shot 2016-11-18 at 2.04.06 PM.png (589×932 px, 115 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2016, 10:07 PM
This revision was automatically updated to reflect the committed changes.