Page MenuHomePhabricator

Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks

Authored by epriestley on Nov 18 2016, 10:07 PM.
Referenced Files
Unknown Object (File)
Apr 10 2017, 7:30 AM
Unknown Object (File)
Apr 8 2017, 2:50 PM
Unknown Object (File)
Feb 11 2017, 8:46 PM
Unknown Object (File)
Jan 31 2017, 2:36 PM
Unknown Object (File)
Dec 23 2016, 4:32 PM
Unknown Object (File)
Dec 15 2016, 9:38 AM
Unknown Object (File)
Dec 9 2016, 9:35 AM
Unknown Object (File)
Dec 7 2016, 8:38 PM



Ref T8345. See T8345#201048 for discussion.

This rule (don't show mentions of or from restricted objects) is more consistent with how we render mentions in the timeline and I think generally a better behavior.

Test Plan
  • Mentioned a task on a public task and a private task.
  • Privileged user (foreground) sees both.
  • Public user (background) sees only the public mention.

Screen Shot 2016-11-18 at 2.04.06 PM.png (589×932 px, 115 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Strip restricted and incomplete handles from the "Mentions" tab on Maniphest tasks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 18 2016, 10:07 PM
This revision was automatically updated to reflect the committed changes.