Fix a bug on Calendar event day views for all day events in certain timezones
ClosedPublic
Actions

Authored by epriestley on Nov 15 2016, 6:19 PM.

Details

Reviewers

chad

Maniphest Tasks

T11816: Calendar: Feedback and Suggestions

Commits

rP6464934cd6be: Fix a bug on Calendar event day views for all day events in certain timezones

Summary

Ref T11816. This logic was correct, we just did all the work and then mostly threw away the results. This worked correctly anyway in some timezones.

Instead, actually use $min_date and $max_date.

Test Plan

In "America/Toronto" with server in a more-western timezone, viewed a "Nov 11 - Nov 12" all-day event, saw those dates.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40611.Nov 15 2016, 6:19 PM

epriestley retitled this revision from to Fix a bug on Calendar event day views for all day events in certain timezones.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11816: Calendar: Feedback and Suggestions.

chad accepted this revision.Nov 15 2016, 6:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2016, 6:23 PM

Closed by commit rP6464934cd6be: Fix a bug on Calendar event day views for all day events in certain timezones (authored by epriestley, committed by epriestley). · Explain WhyNov 15 2016, 7:10 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T11816: Calendar: Feedback and Suggestions.Nov 15 2016, 7:46 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

10 lines

Diff 40615

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Fix a bug on Calendar event day views for all day events in certain timezonesClosedPublicActions