Page MenuHomePhabricator

In Maniphest, don't render the task graph drawing if we're only showing parents/children
ClosedPublic

Authored by epriestley on Nov 7 2016, 7:08 PM.
Tags
None
Referenced Files
F14707957: D16816.id40494.diff
Fri, Jan 17, 7:42 AM
Unknown Object (File)
Fri, Jan 3, 12:29 AM
Unknown Object (File)
Sun, Dec 29, 11:02 PM
Unknown Object (File)
Wed, Dec 25, 2:08 PM
Unknown Object (File)
Dec 16 2024, 2:58 PM
Unknown Object (File)
Dec 11 2024, 10:04 AM
Unknown Object (File)
Dec 7 2024, 3:41 PM
Unknown Object (File)
Dec 3 2024, 2:06 PM
Subscribers
None

Details

Summary

Ref T4788. I thought I implemented this, but actualy didn't.

When we're in the "mid-sized" fallback mode (graph has more than 100 nodes, but not more than than 100 parents/children), don't actually draw the graph. It's almost always uninteresting and huge.

Instead, this just renders a list of direct parents, then the task, then the direct children, which is pretty straightforward.

Test Plan

Set limit to 5, saw mid-sized fallback graph with no actual graph drawing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to In Maniphest, don't render the task graph drawing if we're only showing parents/children.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 7:09 PM
This revision was automatically updated to reflect the committed changes.