Page MenuHomePhabricator

In Maniphest, don't render the task graph drawing if we're only showing parents/children
ClosedPublic

Authored by epriestley on Nov 7 2016, 7:08 PM.

Details

Summary

Ref T4788. I thought I implemented this, but actualy didn't.

When we're in the "mid-sized" fallback mode (graph has more than 100 nodes, but not more than than 100 parents/children), don't actually draw the graph. It's almost always uninteresting and huge.

Instead, this just renders a list of direct parents, then the task, then the direct children, which is pretty straightforward.

Test Plan

Set limit to 5, saw mid-sized fallback graph with no actual graph drawing.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to In Maniphest, don't render the task graph drawing if we're only showing parents/children.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2016, 7:09 PM
This revision was automatically updated to reflect the committed changes.