Page MenuHomePhabricator

Fix a bug which could cause imported events to set themselves as their own parents
ClosedPublic

Authored by epriestley on Nov 2 2016, 6:34 PM.
Tags
None
Referenced Files
F19030809: D16793.diff
Mon, Nov 24, 10:15 PM
F18992443: D16793.id40442.diff
Wed, Nov 19, 3:02 AM
F18870172: D16793.diff
Tue, Nov 4, 3:53 PM
F18809629: D16793.id.diff
Oct 19 2025, 3:42 PM
F18807748: D16793.diff
Oct 19 2025, 3:20 AM
F18762451: D16793.id40443.diff
Oct 6 2025, 7:05 PM
F18733428: D16793.id.diff
Sep 30 2025, 10:34 PM
F18602754: D16793.id.diff
Sep 13 2025, 4:02 PM
Subscribers
None

Details

Summary

Ref T11808. This variable is wrong, and would sometimes cause events to set themsevles as their own parents. They would then fail to load, and disrupt cursor paging.

Test Plan
  • Reproduced T11808 locally by reloading test data 2+ times, creating events with themselves as their own parents.
  • Appplied fix.
  • Nuked data, reloaded, no more self-parents.
  • Test datafile:

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a bug which could cause imported events to set themselves as their own parents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 2 2016, 6:43 PM
This revision was automatically updated to reflect the committed changes.