Page MenuHomePhabricator

Fix a bug which could cause imported events to set themselves as their own parents
ClosedPublic

Authored by epriestley on Nov 2 2016, 6:34 PM.
Tags
None
Referenced Files
F15577902: D16793.id40443.diff
Tue, May 6, 4:46 PM
F15567860: D16793.id40442.diff
Fri, May 2, 4:37 PM
F15525500: D16793.id40442.diff
Mon, Apr 21, 2:53 PM
F15514369: D16793.id40442.diff
Fri, Apr 18, 2:15 AM
F15491661: D16793.id40443.diff
Sat, Apr 12, 6:01 AM
F15490533: D16793.id40442.diff
Fri, Apr 11, 6:13 PM
F15490312: D16793.id.diff
Fri, Apr 11, 4:08 PM
F15488227: D16793.diff
Thu, Apr 10, 8:31 PM
Subscribers
None

Details

Summary

Ref T11808. This variable is wrong, and would sometimes cause events to set themsevles as their own parents. They would then fail to load, and disrupt cursor paging.

Test Plan
  • Reproduced T11808 locally by reloading test data 2+ times, creating events with themselves as their own parents.
  • Appplied fix.
  • Nuked data, reloaded, no more self-parents.
  • Test datafile:

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a bug which could cause imported events to set themselves as their own parents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 2 2016, 6:43 PM
This revision was automatically updated to reflect the committed changes.