Page MenuHomePhabricator
Differential D16784

Automatically send (not-so-great) email notifications for upcoming events
ClosedPublic
Actions

Authored by epriestley on Nov 1 2016, 5:40 PM.

Details

Reviewers
chad
Maniphest Tasks
T7931: Create Calendar triggers which notify users before meetings
Commits
rP6b16f930c47c: Automatically send (not-so-great) email notifications for upcoming events
Summary

Ref T7931. This is still quite rough, but should technically send vaguely-useful email as part of the standard trigger infrastructure.

Test Plan

Ran bin/phd start, created an event shortly, saw reminder email send in bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Branch
calendar11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14314
Build 18627: Run Core Tests
Build 18626: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40422.Nov 1 2016, 5:40 PM
epriestley retitled this revision from to Automatically send (not-so-great) email notifications for upcoming events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7931: Create Calendar triggers which notify users before meetings.
epriestley mentioned this in T7931: Create Calendar triggers which notify users before meetings.Nov 1 2016, 5:47 PM
epriestley updated this revision to Diff 40424.Nov 1 2016, 5:49 PM
  • Tweak some windows and waits, so we try to always send a 15-minute warning instead of a 10-15ish minute warning.
chad accepted this revision.Nov 1 2016, 8:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 8:10 PM
Closed by commit rP6b16f930c47c: Automatically send (not-so-great) email notifications for upcoming events (authored by epriestley, committed by epriestley). · Explain WhyNov 1 2016, 8:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
calendar/
management/
17 lines
notifications/
61 lines
149 lines
infrastructure/
daemon/
workers/
20 lines

Diff 40424

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/management/PhabricatorCalendarManagementNotifyWorkflow.php

Loading...
View Options

src/applications/calendar/notifications/PhabricatorCalendarEventNotificationView.php

Loading...
View Options

src/applications/calendar/notifications/PhabricatorCalendarNotificationEngine.php

Loading...
View Options

src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

Loading...
Phabricator · Built by Phacility