Use "book" instead of "life ring" icon for global help menu
ClosedPublic
Actions

Authored by epriestley on Oct 28 2016, 9:04 PM.

Tags

None

Referenced Files

	F15427034: D16765.id40374.diff
	Sun, Mar 23, 12:16 PM

	F15422833: D16765.diff
	Sat, Mar 22, 11:00 AM

	F15419863: D16765.id40377.diff
	Fri, Mar 21, 9:30 AM

	F15409581: D16765.id40374.diff
	Wed, Mar 19, 4:43 AM

	F15382566: D16765.id40377.diff
	Fri, Mar 14, 1:09 PM

	F15369291: D16765.id40374.diff
	Wed, Mar 12, 6:02 AM

	F15333470: D16765.id40374.diff
	Sat, Mar 8, 2:30 AM

	F15332515: D16765.diff
	Fri, Mar 7, 5:39 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPa792faf78d82: Use "book" instead of "life ring" icon for global help menu

Summary

This is more consistent with the icon we use for documentation elsewhere.

Test Plan

Looked at the icon, had an easier time guessing it meant "documentation".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40374.Oct 28 2016, 9:04 PM

epriestley retitled this revision from to Use "book" instead of "life ring" icon for global help menu.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Oct 28 2016, 9:06 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 28 2016, 9:06 PM

Closed by commit rPa792faf78d82: Use "book" instead of "life ring" icon for global help menu (authored by epriestley, committed by epriestley). · Explain WhyOct 28 2016, 9:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

help/

extension/

PhabricatorHelpMainMenuBarExtension.php

2 lines

Diff 40377

View Options

src/applications/help/extension/PhabricatorHelpMainMenuBarExtension.php

Use "book" instead of "life ring" icon for global help menuClosedPublicActions