Page MenuHomePhabricator

Hold a lock while collecting garbage
ClosedPublic

Authored by epriestley on Oct 20 2016, 6:40 PM.

Details

Summary

Fixes T11771. Adds a lock around each GC process so we don't try to, e.g., delete old files on two machines at once just because they're both running trigger daemons.

The other aspects of this daemon (actual triggers; nuance importers) already have separate locks.

Test Plan

Ran bin/phd debug trigger --trace, saw daemon acquire locks and collect garbage.

Diff Detail

Repository
rP Phabricator
Branch
gclock
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 14199
Build 18455: Run Core Tests
Build 18454: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40307.Oct 20 2016, 6:40 PM
epriestley retitled this revision from to Hold a lock while collecting garbage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 20 2016, 7:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2016, 7:44 PM
This revision was automatically updated to reflect the committed changes.