Page MenuHomePhabricator

Hold a lock while collecting garbage
ClosedPublic

Authored by epriestley on Oct 20 2016, 6:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 1:50 PM
Unknown Object (File)
Thu, Dec 12, 6:51 PM
Unknown Object (File)
Wed, Dec 11, 2:20 PM
Unknown Object (File)
Wed, Dec 11, 11:01 AM
Unknown Object (File)
Fri, Dec 6, 10:04 AM
Unknown Object (File)
Mon, Dec 2, 2:17 PM
Unknown Object (File)
Sat, Nov 30, 4:36 PM
Unknown Object (File)
Sun, Nov 24, 7:22 PM
Subscribers
None

Details

Summary

Fixes T11771. Adds a lock around each GC process so we don't try to, e.g., delete old files on two machines at once just because they're both running trigger daemons.

The other aspects of this daemon (actual triggers; nuance importers) already have separate locks.

Test Plan

Ran bin/phd debug trigger --trace, saw daemon acquire locks and collect garbage.

Diff Detail

Repository
rP Phabricator
Branch
gclock
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14199
Build 18455: Run Core Tests
Build 18454: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Hold a lock while collecting garbage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2016, 7:44 PM
This revision was automatically updated to reflect the committed changes.