Page MenuHomePhabricator
Differential D16655

Clean up nux state with durable column
ClosedPublic
Actions

Authored by chad on Oct 3 2016, 5:29 PM.
Tags
None
Referenced Files
F14056961: D16655.diff
Sat, Nov 16, 11:41 PM
F14031991: D16655.diff
Sat, Nov 9, 12:30 PM
F14008679: D16655.id40093.diff
Wed, Oct 30, 4:16 AM
Unknown Object (File)
Oct 2 2024, 8:47 AM
Unknown Object (File)
Sep 26 2024, 9:58 PM
Unknown Object (File)
Sep 25 2024, 10:52 AM
Unknown Object (File)
Sep 16 2024, 2:45 AM
Unknown Object (File)
Sep 13 2024, 10:03 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP1d00bc918019: Clean up nux state with durable column
Summary

Remove policy icons from durable column, create a basic nux layout and style.

Test Plan

leave all rooms, pop open chat, see helpful text and button.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40092.Oct 3 2016, 5:29 PM
chad retitled this revision from to Clean up nux state with durable column.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 3 2016, 5:29 PM
chad updated this revision to Diff 40093.Oct 3 2016, 5:33 PM
  • also remove policy icon css
epriestley accepted this revision.Oct 3 2016, 5:49 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 5:49 PM
Closed by commit rP1d00bc918019: Clean up nux state with durable column (authored by chad, committed by chad). · Explain WhyOct 3 2016, 6:30 PM
This revision was automatically updated to reflect the committed changes.
ralph.van.etten mentioned this in T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content.Oct 25 2016, 6:57 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
conpherence/
view/
53 lines
webroot/
rsrc/
css/
application/
conpherence/
21 lines

Diff 40095

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
Phabricator · Built by Phacility