Add inline styles for `{key ...}` in HTML mail
ClosedPublic
Actions

Authored by epriestley on Sep 8 2016, 11:39 PM.

Details

Reviewers

chad

Maniphest Tasks

T11607: Put inline styles on `{key ...}` for email

Commits

rP17cd119b91a5: Add inline styles for `{key ...}` in HTML mail

Summary

Fixes T11607.

Test Plan

Made a comment using {key ...}.
Used bin/mail show-outbound --id X --dump-html > test.html to review HTML:

Screen Shot 2016-09-08 at 4.38.06 PM.png (1×1 px, 109 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39762.Sep 8 2016, 11:39 PM

epriestley retitled this revision from to Add inline styles for `{key ...}` in HTML mail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11607: Put inline styles on `{key ...}` for email.

chad accepted this revision.Sep 9 2016, 12:08 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 9 2016, 12:08 AM

some day we will be able to write all our CSS in PHP so we don't have to do this :3

Closed by commit rP17cd119b91a5: Add inline styles for `{key ...}` in HTML mail (authored by epriestley, committed by epriestley). · Explain WhySep 9 2016, 12:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

rule/

PhabricatorKeyboardRemarkupRule.php

31 lines

Diff 39763

View Options

src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php

Add inline styles for `{key ...}` in HTML mailClosedPublicActions