diff --git a/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php b/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php --- a/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php +++ b/src/applications/xhprof/controller/PhabricatorXHProfProfileController.php @@ -47,11 +47,12 @@ $crumbs = $this->buildApplicationCrumbs(); $crumbs->addTextCrumb(pht('%s Profile', $symbol)); - return $this->buildStandardPageResponse( - array($crumbs, $view), - array( - 'title' => pht('Profile'), - 'frame' => $is_framed, - )); + $title = pht('Profile'); + + return $this->newPage() + ->setTitle($title) + ->setCrumbs($crumbs) + ->setFrameable(true) + ->appendChild($view); } } diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php --- a/src/view/page/PhabricatorStandardPageView.php +++ b/src/view/page/PhabricatorStandardPageView.php @@ -21,6 +21,7 @@ private $quicksandConfig = array(); private $crumbs; private $navigation; + private $frameable = false; public function setShowFooter($show_footer) { $this->showFooter = $show_footer; @@ -85,6 +86,15 @@ return $this; } + public function setFrameable($frameable) { + $this->frameable = $frameable; + return $this; + } + + public function getFrameable() { + return $this->frameable; + } + public function setShowDurableColumn($show) { $this->showDurableColumn = $show; return $this; @@ -890,7 +900,8 @@ } else { $content = $this->render(); $response = id(new AphrontWebpageResponse()) - ->setContent($content); + ->setContent($content) + ->setFrameable($this->frameable); } return $response;