Page MenuHomePhabricator
Differential D16369

Clean up some tablet issues with new nav layouts
ClosedPublic
Actions

Authored by chad on Aug 4 2016, 8:38 PM.
Tags
None
Referenced Files
F15540004: D16369.diff
Fri, Apr 25, 6:21 AM
F15518554: D16369.id.diff
Sat, Apr 19, 2:30 PM
F15515926: D16369.diff
Fri, Apr 18, 2:37 PM
F15367474: D16369.diff
Mar 11 2025, 6:52 PM
F15364364: D16369.id39369.diff
Mar 11 2025, 1:24 PM
Unknown Object (File)
Feb 16 2025, 7:12 AM
Unknown Object (File)
Feb 12 2025, 6:19 PM
Unknown Object (File)
Feb 12 2025, 4:26 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP1dd9c37fdf20: Clean up some tablet issues with new nav layouts
Summary

Makes sidenav disappear again on projects/profiles, but shows it on home again (tablet views).

Test Plan

Visit Profile/Projects/Home on mobile, desktop, and tablet. See nav disappear correctly.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Skipped
Unit
Tests Passed
Build Status
Buildable 13247
Build 16978: Run Core Tests
Build 16977: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39369.Aug 4 2016, 8:38 PM
chad retitled this revision from to Clean up some tablet issues with new nav layouts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 4 2016, 8:38 PM
epriestley accepted this revision.Aug 4 2016, 8:40 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2016, 8:40 PM
Closed by commit rP1dd9c37fdf20: Clean up some tablet issues with new nav layouts (authored by chad, committed by chad). · Explain WhyAug 4 2016, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
home/
controller/
1 line
webroot/
rsrc/
css/
aphront/
6 lines
phui/
9 lines

Diff 39369

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-basic-nav-view.css

Loading...
Phabricator · Built by Phacility