Page MenuHomePhabricator
Differential D16369

Clean up some tablet issues with new nav layouts
ClosedPublic
Actions

Authored by chad on Aug 4 2016, 8:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 8:21 PM
Unknown Object (File)
Thu, Dec 5, 4:49 AM
Unknown Object (File)
Tue, Nov 26, 11:56 PM
Unknown Object (File)
Fri, Nov 22, 9:38 PM
Unknown Object (File)
Nov 18 2024, 5:47 AM
Unknown Object (File)
Nov 10 2024, 12:46 PM
Unknown Object (File)
Nov 9 2024, 12:07 PM
Unknown Object (File)
Nov 9 2024, 12:07 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP1dd9c37fdf20: Clean up some tablet issues with new nav layouts
Summary

Makes sidenav disappear again on projects/profiles, but shows it on home again (tablet views).

Test Plan

Visit Profile/Projects/Home on mobile, desktop, and tablet. See nav disappear correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39369.Aug 4 2016, 8:38 PM
chad retitled this revision from to Clean up some tablet issues with new nav layouts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 4 2016, 8:38 PM
epriestley accepted this revision.Aug 4 2016, 8:40 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2016, 8:40 PM
Closed by commit rP1dd9c37fdf20: Clean up some tablet issues with new nav layouts (authored by chad, committed by chad). · Explain WhyAug 4 2016, 8:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
home/
controller/
1 line
webroot/
rsrc/
css/
aphront/
6 lines
phui/
9 lines

Diff 39370

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...
View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-basic-nav-view.css

Loading...
Phabricator · Built by Phacility