Show event icons in header instead of property list
ClosedPublic
Actions

Authored by epriestley on Jul 14 2016, 11:52 AM.

Tags

None

Referenced Files

	F15468602: D16297.id39198.diff
	Fri, Apr 4, 2:52 AM

	F15464222: D16297.diff
	Wed, Apr 2, 7:27 AM

	F15455481: D16297.id39198.diff
	Sun, Mar 30, 12:44 AM

	F15454768: D16297.diff
	Sat, Mar 29, 8:15 PM

	F15448085: D16297.id39198.diff
	Fri, Mar 28, 3:12 AM

	F15448084: D16297.id39194.diff
	Fri, Mar 28, 3:12 AM

	F15446588: D16297.diff
	Thu, Mar 27, 7:36 PM

	F15443166: D16297.id39194.diff
	Thu, Mar 27, 2:49 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T11326: Improve Calendar v1 Design/UI/UX

Commits

rP04a69fa31343: Show event icons in header instead of property list

Summary

Ref T11326. Currently, events show the icon as a property, like this:

Icon: Default

This is boring and terrible. Show the icon in the header instead:

Screen Shot 2016-07-14 at 4.51.03 AM.png (96×227 px, 10 KB)

Also minor cleanup on active/cancel states.

Test Plan

Viewed an event, saw icon.

Diff Detail

Repository

rP Phabricator

Branch

calx2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13074
Build 16712: Run Core Tests
Build 16711: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39194.Jul 14 2016, 11:52 AM

epriestley retitled this revision from to Show event icons in header instead of property list.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11326: Improve Calendar v1 Design/UI/UX.

chad accepted this revision.Jul 14 2016, 1:56 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 14 2016, 1:56 PM

Closed by commit rP04a69fa31343: Show event icons in header instead of property list (authored by epriestley, committed by epriestley). · Explain WhyJul 14 2016, 2:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventViewController.php

23 lines

Diff 39194

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Show event icons in header instead of property listClosedPublicActions