Page MenuHomePhabricator

For now, hard limit task graph at 100 nodes
ClosedPublic

Authored by epriestley on Jul 14 2016, 4:10 AM.
Tags
None
Referenced Files
F12838747: D16295.id39192.diff
Thu, Mar 28, 6:35 PM
Unknown Object (File)
Sat, Mar 16, 6:47 AM
Unknown Object (File)
Feb 18 2024, 10:58 AM
Unknown Object (File)
Feb 18 2024, 10:58 AM
Unknown Object (File)
Feb 18 2024, 10:58 AM
Unknown Object (File)
Feb 13 2024, 10:00 AM
Unknown Object (File)
Feb 12 2024, 12:02 AM
Unknown Object (File)
Feb 11 2024, 2:56 PM
Subscribers
None

Details

Summary

Ref T4788. One install has some particularly impressive task graphs which are thousands of nodes large.

The current graph is pretty broken in these cases. For now, just render a "too big to show" message. In the future, I'd plan to finesse this (e.g., show parents/children, show links to parents/children, etc).

Test Plan
  • Viewed a normal task.
  • Set limit to 3, viewed a task with graph size 6, saw an error message.
  • Viewed a revision stack graph (unaffected).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to For now, hard limit task graph at 100 nodes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 14 2016, 4:12 AM
This revision was automatically updated to reflect the committed changes.