Differential D16295

For now, hard limit task graph at 100 nodes
ClosedPublic
Actions

Authored by epriestley on Jul 14 2016, 4:10 AM.

Details

Reviewers

chad

Maniphest Tasks

T4788: Allow "Edit Dependencies" both ways (blocking and depending)

Commits

rP2a1b8ce85bef: For now, hard limit task graph at 100 nodes

Summary

Ref T4788. One install has some particularly impressive task graphs which are thousands of nodes large.

The current graph is pretty broken in these cases. For now, just render a "too big to show" message. In the future, I'd plan to finesse this (e.g., show parents/children, show links to parents/children, etc).

Test Plan

Viewed a normal task.
Set limit to 3, viewed a task with graph size 6, saw an error message.
Viewed a revision stack graph (unaffected).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39191.Jul 14 2016, 4:10 AM

epriestley retitled this revision from to For now, hard limit task graph at 100 nodes.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4788: Allow "Edit Dependencies" both ways (blocking and depending).

chad accepted this revision.Jul 14 2016, 4:12 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 14 2016, 4:12 AM

Closed by commit rP2a1b8ce85bef: For now, hard limit task graph at 100 nodes (authored by epriestley, committed by epriestley). · Explain WhyJul 14 2016, 4:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

15 lines

infrastructure/

graph/

PhabricatorObjectGraph.php

24 lines

Diff 39192

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php