Page MenuHomePhabricator

Fix some EditEngine issues with rendering "invite" transactions
ClosedPublic

Authored by epriestley on Jul 12 2016, 8:23 PM.
Tags
None
Referenced Files
F10885151: D16284.id.diff
Fri, Jul 1, 3:21 PM
Unknown Object (File)
Wed, Jun 15, 6:20 AM
Unknown Object (File)
Mon, Jun 13, 11:46 AM
Unknown Object (File)
May 25 2022, 7:42 AM
Unknown Object (File)
May 23 2022, 2:12 AM
Unknown Object (File)
Apr 11 2017, 4:51 PM
Unknown Object (File)
Apr 8 2017, 7:47 AM
Unknown Object (File)
Mar 8 2017, 3:12 AM
Subscribers
None

Details

Summary

Ref T9275. We were rendering too many transactions and/or over-rendering invitees.

Clean this logic up a bit:

  • List all before/after invitees.
  • Simplify the lists before rendering.
Test Plan

Viewed an event, edited invitees, got sensible human-readable transactions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix some EditEngine issues with rendering "invite" transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 12 2016, 10:09 PM
This revision was automatically updated to reflect the committed changes.