Page MenuHomePhabricator

Provide basic support for Subversion revprops
ClosedPublic

Authored by epriestley on Jun 24 2016, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 1:17 AM
Unknown Object (File)
Fri, Dec 13, 7:56 AM
Unknown Object (File)
Fri, Dec 6, 5:06 AM
Unknown Object (File)
Wed, Nov 27, 4:03 AM
Unknown Object (File)
Sat, Nov 23, 3:44 PM
Unknown Object (File)
Nov 20 2024, 7:06 AM
Unknown Object (File)
Nov 19 2024, 12:57 PM
Unknown Object (File)
Nov 15 2024, 6:41 AM
Subscribers
None

Details

Summary

Ref T11208. See that task for a more detailed description of revprops.

This allows revprop changes in a hosted Subversion repository if the repository has the "allow dangerous changes" flag set.

In the future, we could expand this into real Herald support, but the only use case we have for now is letting svnsync work.

Test Plan

Edited revprops with svn propset --revprop -r 2 propkey propvalue repositoryuri:

  • Tried before patch, got a "configure a commit hook" error.
  • Tried after patch, got a "dangerous change" error.
  • Allowed dangerous changes.
  • Did a revprop edit.
  • Prevented dangerous changes.
  • Got an error again.
  • Made a normal commit to an SVN repository.

Diff Detail

Repository
rP Phabricator
Branch
svnprop1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12787
Build 16279: Run Core Tests
Build 16278: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Provide basic support for Subversion revprops.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2016, 6:55 PM
This revision was automatically updated to reflect the committed changes.