Page MenuHomePhabricator

Allow Herald text list fields to use "Exists" / "Does not exist" conditions
ClosedPublic

Authored by epriestley on Jun 21 2016, 4:21 PM.

Details

Summary

This makes it more natural to write Herald rules about commits that appear on any or no branches.

Test Plan

Wrote a commit rule for commits on any branch, ran it with bin/repository reparse --herald <commit>, saw expected results in web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Herald text list fields to use "Exists" / "Does not exist" conditions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

The other field type which uses this is "Affected Files" (for commits and revisions).

(It probably isn't too useful there, but shouldn't hurt anything, and I suppose you could write a commits rule to forbid empty commits.)

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2016, 5:20 PM
This revision was automatically updated to reflect the committed changes.