Fix an ancient ad-hoc string truncation
ClosedPublic
Actions

Authored by epriestley on Jun 13 2016, 5:14 PM.

Tags

None

Referenced Files

	F13806460: D16105.diff
	Mon, Sep 16, 7:11 AM

	Unknown Object (File)
	Thu, Sep 12, 8:33 AM

	Unknown Object (File)
	Fri, Sep 6, 10:15 AM

	Unknown Object (File)
	Thu, Sep 5, 8:43 PM

	Unknown Object (File)
	Sun, Sep 1, 9:28 PM

	Unknown Object (File)
	Sat, Aug 31, 4:06 AM

	Unknown Object (File)
	Mon, Aug 19, 12:10 PM

	Unknown Object (File)
	Aug 15 2024, 1:52 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T11139: Non-latin commit messages are disappear in history view

Commits

rPa5e29f3ffa9a: Fix an ancient ad-hoc string truncation

Summary

Fixes T11139. We missed this years ago when we moved to PhutilUTF8StringTruncator.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

summary1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12624
Build 16031: Run Core Tests
Build 16030: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38747.Jun 13 2016, 5:14 PM

epriestley retitled this revision from to Fix an ancient ad-hoc string truncation.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11139: Non-latin commit messages are disappear in history view.

chad accepted this revision.Jun 13 2016, 5:16 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 13 2016, 5:16 PM

Closed by commit rPa5e29f3ffa9a: Fix an ancient ad-hoc string truncation (authored by epriestley, committed by epriestley). · Explain WhyJun 13 2016, 5:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

data/

DiffusionPathChange.php

4 lines

Diff 38747

View Options

src/applications/diffusion/data/DiffusionPathChange.php

Fix an ancient ad-hoc string truncationClosedPublicActions